Maddie Shields - Edges - Personal Portfolio Site

[madaleines]

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?
Why is it important to consider and use semantic HTML?	Semantic tags make it clear what part of the page is presented
How did you decide to structure your CSS?	One generic large CSS file to apply to multiple pages.
What was the most challenging piece of this assignment?	CSS, particularly with when to use Grid or when to use Flex for optimal results. Keeping a part of the header Fixed, but not the whole part.
Describe one area that you gained more clarity on when completing this assignment	Flex and Grid a bit more
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?	nope, maybe later
Overall

[droberts-sea]

Personal Portfolio Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	yes
Answered comprehension questions	yes
Page fully loads	yes
No broken links (regular or images)	yes
Includes at least 4 pages and styling	yes
HTML
Uses the high-level tags for organization: header, footer, main	yes - good work
Appropriately using semantic tags: section, article, etc.	yes
All images include alternate text	this is missing
CSS
Using class and ID names in style declarations	yes
Style declarations are DRY	It would probably be wise to break your CSS out into multiple files: main.css, which contains the styles applied to every page (like the header and nav), and a stylesheet for each individual page containing specific styles for that page.
Overall

In general this looks good. I like that you're experimenting with animations, embedded content and a CSS framework! Just make sure your fundamentals don't slip as a result.

[droberts-sea]

JavaScript should always live in a separate file. Inline scripts are bad form.

[droberts-sea]

These have inline styles! The width: 100% should go in your CSS.