Liv, Hannah, Corinna - Time&Space #30

mulhoo · 2020-06-19T17:37:56Z

Assignment Submission: bEtsy

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions. These should be answered by all members of your team, not by a single teammate.

Reflection

Prompt	Response
Each team member: what is one thing you were primarily responsible for that you're proud of?	LIV: I'm really proud of the testing. Testing was something I dreaded doing with every project, but was the primary thing I did on this one. I definitely feel a log more comfortable with that now. CORINNA: using session to store our cart, including updating quantities and eventually creating an order. HANNAH: Deployment. This time, I deployed early and often (every day). Especially, implementing OAuth on Heroku is something I learned and I’m proud of!
Each team member: what is one thing you were primarily responsible for that you would like targeted feedback on?	LIV: the setup in the test helper, and where throughout the tests I could further utilize it to make my test files DRY-er. CORINNA: Places where I could use additional test helpers or move methods to make the code cleaner and more efficient. I struggled to use things like before_action because my params often changed from ['id'] to ['format'] so accommodating for that, etc. HANNAH: products_contoller & model! I mainly worked on products related controllers like ‘reviews_controller’ and ‘category_controller’. I made sure to use before_action, around_action to make my code DRY.
How did your team break up the work to be done?	Once the first wave of major deliverables was complete, we broke off features one at a time, using Trello to keep track of who was working on what, to make the rest of the build more manageable. Corinna and Hannah handled the views and a lot of the controller stuff (ass well as CSS), as well as the products/users models. Corinna also did the ERD. Liv did initial setup, testing and other model stuff, also some work in order/order items controller. Hannah mainly focused on products, categories, reviews controllers and models and their relationship. Also, she debugged testings to improve test coverage and worked on deployment.
How did your team utilize git to collaborate?	So many branches. Branches on branches. A forrest worth of branches.
What did your group do to try to keep your code DRY while many people collaborated on it?	commenting out code that seemed extraneous or wordy with new code and clearing the remaining at the end? Because we knew the code worked, we were just cleaning. Also just communicating via slack about what we were doing. We added a method that mostly used every controller in application_controller, and used `before_action` and `around_action` to dry our code.
What was a technical challenge that you faced as a group?	Deployment and Heroku debugging.
What was a team/personal challenge that you faced as a group?	As a whole, not too many! I (Liv) personally really enjoyed working with both Corinna and Hannah - they're absolute work horses! The only one we could come up with was knowing when to cut ourselves off from upgrading features and optimizing.
What was your application's ERD? (upload this to Google Drive, change the share settings to viewable by everyone with a link, and include a link)	https://drive.google.com/file/d/1qkeYUZruSNNcNA6UCqpdBDmXa1Qs-Hjt/view?usp=sharing
What is your Trello URL?	https://trello.com/invite/b/UPxP6Dnt/0e2a30755acb0cc446925e053c7f3aab/nooksy
What is the Heroku URL of your deployed application?	http://nooksy.herokuapp.com

…ubmitted

…hash

merge from testing

beccaelenzil

LIV: I love how you divided your tests into what you can do unauthenticated and what you can do authenticated. This is a great way to use login from the test helper. Overall, I feel like your tests are quite clean and make good use of this test_helper method and fixtures. If there are specific places where you thought it could be DRYer, I'd be happy to chat about it. In general, tests are the one place not to worry too much about DRYness.

CORINNA: I left in an in-line comment about the controller filter conundrum. It's ok to not use controller filters if you're not writing the same code more than a couple times. Again, if there are specific places in the tests, I'd be happy to chat about how you might be able to write a test_helper method to make things more concise.

HANNAH: Great use of controller filters and custom model methods. I left one in-line comment of a small amount of logic you could consider putting in the model.

beccaelenzil · 2020-06-24T14:47:12Z

app/controllers/orders_controller.rb

+  end
+
+  def ordered
+    @order = Order.find_by(id: params['id'])


Per your question, it's ok to not have a controller filter here since this code is only repeated twice. You could chose to use a controller filter for the 'id' one and not the 'format' one.

beccaelenzil · 2020-06-24T14:48:34Z

app/controllers/orderitems_controller.rb

+    product = Product.find_by(id: params["format"]).inventory
+
+
+    session[:cart].each do |item|


Consider whether you can move any of this logic to a model method.

beccaelenzil · 2020-06-24T14:49:24Z

app/controllers/orderitems_controller.rb

+    quantity = params["quantity"].to_i
+
+    session[:cart].each do |item|
+      if item['product_id'] == product.id 


Consider whether you can move any of this logic to a model method.

beccaelenzil · 2020-06-24T14:51:12Z

app/controllers/orderitems_controller.rb

+        return
+      end
+
+      if item["product_id"] == params['format'].to_i


Consider moving this business logic to the model.

beccaelenzil · 2020-06-24T14:52:53Z

app/controllers/users_controller.rb

+    @shipped_revenue = 0
+    @shipped_count = 0
+
+    Order.all.each do |order|


These calculations should be done in custom model methods.

beccaelenzil · 2020-06-24T15:45:37Z

app/controllers/orders_controller.rb

+      order.order_items.each do |item|
+        merchant_product = Product.find_by(id: item.product_id)
+
+        if session[:user_id] == merchant_product.user_id


This logic seems like it could go into the merchant model so that you could use something like merchant.orders

beccaelenzil · 2020-06-24T15:47:25Z

app/controllers/products_controller.rb

+
+
+  def index 
+    @products = Product.where(active: true).order(:name).paginate(:page=>params[:page],:per_page=>15)


you could consider during some of this work in a custom model method such as active_sorted_products.

beccaelenzil · 2020-06-24T15:48:31Z

app/models/product.rb

@@ -0,0 +1,66 @@
+class Product < ApplicationRecord


Great use of custom model methods

beccaelenzil · 2020-06-24T15:49:20Z

app/models/order.rb

+    return order_total
+  end
+
+  def self.get_items(merchant_products)


I like this method! Do you use it?

beccaelenzil · 2020-06-24T15:50:37Z

app/views/products/_search_result.html.erb

@@ -0,0 +1,15 @@
+<div class="products__index_product-container item">


Great use of a partial view

beccaelenzil · 2020-06-24T15:53:21Z

bEtsy

Functional Requirements: Manual Testing

Workflow	yes / no
Deployed to Heroku
Before logging in
Browse all products, by category, by merchant	✔️
Leave a review	✔️
Verify unable to create a new product	✔️
After logging in
Create a category	✔️
Create a product in that category with stock 10	✔️
Add the product you created to your cart	✔️
Add it again (should update quantity)	✔️(this will update when I check out)
Verify unable to increase quantity beyond stock	✔️
Add another merchant's product	✔️
Check out	✔️
Check that stock was reduced	✔️
Change order-item's status on dashboard	✔️
Verify unable to leave a review for your own product	✔️
Verify unable to edit another merchant's product by manually editing URL	✔️
Verify unable to see another merchant's dashboard by manually editing URL	✔️

Major Learning Goals/Code Review

Criteria	yes / no
90% reported coverage for all controller and model classes using SimpleCov	OrderItems, Order, and Users controllers all have coverage that is a bit low. The lines that are not covered seem to include some business that could perhaps be delegated to a model method that could then be tested.
Routes
No un-needed routes generated (check `reviews`)	✔️
Routes not overly-nested (check products and merchants)	✔️
Merchant dashboard and cart page use a non-parameterized routes (should pull merchant or cart ID from session)	✔️
Controllers
Controller-filter to require login by default	✔️
Helper methods or filters to find logged-in user, cart, product, etc	✔️
No excessive business logic	✔️
Business logic that ought to live in the model
Add / remove / update product on order	See in-line comments pointing out business logic in controller
Checkout -> decrease inventory	See in-line comments pointing out business logic in controller
Merchant's total revenue	See in-line comments pointing out business logic in controller
Find all orders for this merchant (instance method on `Merchant`)	Is this the method `get_items` on the `Order` model -- I don't see where this is used.
Selected Model Tests
Add item to cart: - Can add a good product - Can't add a product w/o enough stock - Can't add a retired product - Can't add to an order that's not in cart mode - Logic specific to this implementation	This logic is largely in the controller and not thoroughly tested. This it's what's bringing your test coverage down on orders_controller.
Get orders for this merchant: - Includes all orders from this merchant - Doesn't include orders from another merchant - Orders are not included more than once - Does something reasonable when there are no orders for this merchant	✔️Similar to above, this logic is in the controller, and not thoroughly tested. By moving this logic to the model, it will likely be more straightforward to test.
Selected Controller Tests
Add item to cart: - Empty cart (should be created) - Cart already exists (should add to same order) - Product already in cart (should update quantity) - Bad product ID, product is retired, quantity too high, or something like that (error)	I see some of these tests, but some are missing.
Leave a review: - Works when not logged in - Works when logged in as someone other than the product's merchant - Doesn't work if logged in as this product's merchant - Doesn't work if validations fail	✔️thorough testing!

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever	✅
Descriptive/Readable	✅
Concise	✅
Logical/Organized	✅

Overall Feedback

Only the person who submitted the PR will get an email about this feedback. Please let the rest of your team know about it.

Hannah0124 and others added 30 commits June 13, 2020 13:26

Update partial views

2d21aed

category and review tests complete

cf20b79

review relationships tests

c153f44

Cart updates quantity and quantity is the correct number originally s…

8ddd7f7

…ubmitted

Merged conflicts

a4a73b6

Merge branch 'view_cart'

309eb72

Temporary show page fix

e9f2260

product testing

d321612

product test and user test

b1ba59a

changed auth route :provider to github

a636d81

added rails controller testing gem

7457af1

all controller tests passing

106cdf5

Changed format of cart and updated to accomodate an array instead of …

683758d

…hash

pages controller tests, passing

3189970

Quantity can be increased on cart page

0a419a6

Removes items from quantities in cart view

b8bab35

products controller tests, all but 2destroy pass

6c949ca

user tests, 8 total failurs

0b863c3

Merge pull request #1 from mulhoo/testing

cc3f770

merge from testing

small change to review test

a722b4f

Clean code

003ec5c

Update and clean item and review seeds

9bb75a6

Refactor category controller & views (index, show)

295e839

Display 'add to cart' button only if items are active

ea00a7f

Refactor products controller & model & form view

006de31

Refactor _search_result.html.erb

0e8329a

order model

f67fc0c

orders schema update

1815063

order tests

1fd3dc2

orders column, name

c72350d

Hannah0124 and others added 23 commits June 18, 2020 12:20

Imporve test coverage in categories_controller

36cbd48

Merge branch 'master' into final_tests

6a945a1

Merge branch 'master' into final_tests

f7f41d7

Fix a minor issue in _form.html.erb for products

e1d5305

Modified seeds.rb

7ed851c

Merge branch 'master' of https://github.com/mulhoo/betsy

d038945

Updated order_item_test.rb to 100%

df2e0a9

Minor test update

1b2c9d1

Modify review part

9668726

Fixed dashboard

832aea2

Merge branch 'master' of https://github.com/mulhoo/betsy

bc246b2

Improve test coverage for orderitems, users, orders controllers

60d6147

test

21fc5c7

Fix bugs in dashboard

ed5291f

Add purchased items in final order page

0e049c8

Fixed a bug in my orders page

2e8a0db

order testsing

01caad4

merge from final_tests

76bf12e

Fix a bug

c73a6ba

code clean up

a2023a9

Merge branch 'master' of https://github.com/mulhoo/betsy

8224a8e

Fix bugs in orderitems_controller_test & orders_controller_test

f4d91bc

Clean code

5aa9688

beccaelenzil reviewed Jun 24, 2020

View reviewed changes

app/models/product.rb

@@ -0,0 +1,66 @@

class Product < ApplicationRecord

Copy link

beccaelenzil Jun 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of custom model methods

beccaelenzil reviewed Jun 24, 2020

View reviewed changes

app/models/order.rb

return order_total

end

def self.get_items(merchant_products)

Copy link

beccaelenzil Jun 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this method! Do you use it?

beccaelenzil reviewed Jun 24, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Liv, Hannah, Corinna - Time&Space #30

Liv, Hannah, Corinna - Time&Space #30

mulhoo commented Jun 19, 2020 •

edited

Loading

beccaelenzil left a comment •

edited

Loading

beccaelenzil Jun 24, 2020

beccaelenzil Jun 24, 2020

beccaelenzil Jun 24, 2020

beccaelenzil Jun 24, 2020

beccaelenzil Jun 24, 2020

beccaelenzil Jun 24, 2020

beccaelenzil Jun 24, 2020

beccaelenzil Jun 24, 2020

beccaelenzil Jun 24, 2020

beccaelenzil Jun 24, 2020

beccaelenzil commented Jun 24, 2020

		product = Product.find_by(id: params["format"]).inventory


		session[:cart].each do \|item\|



		def index
		@products = Product.where(active: true).order(:name).paginate(:page=>params[:page],:per_page=>15)

		@@ -0,0 +1,15 @@
		<div class="products__index_product-container item">

Liv, Hannah, Corinna - Time&Space #30

Are you sure you want to change the base?

Liv, Hannah, Corinna - Time&Space #30

Conversation

mulhoo commented Jun 19, 2020 • edited Loading

Assignment Submission: bEtsy

Reflection

beccaelenzil left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

beccaelenzil commented Jun 24, 2020

bEtsy

Functional Requirements: Manual Testing

Major Learning Goals/Code Review

Code Style Bonus Awards

Overall Feedback

Only the person who submitted the PR will get an email about this feedback. Please let the rest of your team know about it.

mulhoo commented Jun 19, 2020 •

edited

Loading

beccaelenzil left a comment •

edited

Loading