Lak, Jeta, Ross, Yaz #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he model for changing cancelled status as well as other status error checking in order model
…ve conditional functionality on dashboard
…lationship Products categories relationship
Ross order model tests
Orders controller tests passing
Merchant dashboard
…more thorough testing of flash to controller tests
changed product model test to reflect changes to active field, added …
Routes clean up
add withd and height
Fix nav font
Status filter
Last merchants tests
CheezItMan
reviewed
Jun 30, 2020
| end | ||
| end | ||
|
|
||
| describe "order" do |
There was a problem hiding this comment.
You don't seem to have a nominal case here where the merchant browses orders and filters by status.
| return true | ||
| end | ||
|
|
||
| def self.filter_status(order_items, status) |
There was a problem hiding this comment.
This method never seems to get called
|
|
||
| private | ||
|
|
||
| def change_items(change) |
There was a problem hiding this comment.
If you run into any validations here, you should then rollback all the other submissions.
|
|
||
| def submit_order | ||
| @order.submit_order | ||
| if filter_cc && @order.update(order_params) |
There was a problem hiding this comment.
If the validation fails here, you need to rollback all the order_item changes!
| @@ -0,0 +1,92 @@ | |||
| class ProductsController < ApplicationController | |||
There was a problem hiding this comment.
You should have a filter here that requires The logged in person to be the owner before letting them edit, or delete products!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: bEtsy
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions. These should be answered by all members of your team, not by a single teammate.
Reflection