Alexis Miller - Cheetahs #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const onLike = (id) => { | ||
| setMessageData((messageData) => | ||
| messageData.map((message) => { |
There was a problem hiding this comment.
I'd recommend trying to avoid having too many nested functions. This totally works, but it doesn't have the best readability. more readable = easier to maintain 😌
| const [messageData, setMessageData] = useState(chatMessages); | ||
|
|
||
| const onLike = (id) => { | ||
| setMessageData((messageData) => |
There was a problem hiding this comment.
you don't have to pass messageData as an argument here since it's globally available in App.
| }; | ||
|
|
||
| const calcTotalLikes = (messageData) => { | ||
| return messageData.reduce((total, message) => { |
| ); | ||
| }; | ||
|
|
||
| ChatLog.propTypes = { |
| <p className="entry-time">Replace with TimeStamp component</p> | ||
| <button className="like">🤍</button> | ||
| <p>{body}</p> | ||
| <p className="entry-time"> |
There was a problem hiding this comment.
I would recommend using a div here instead of a paragraph tag since it isn't a good semantic representation of the time stamp content. Or maybe not wrapping the component in another tag at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.