Tigers - Mica and Misha #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spitsfire
reviewed
Jan 20, 2023
Comment on lines
+11
to
+15
| <header class="titleBlock"> | ||
| <h1 id="siteTitle">The Weather Station</h1> | ||
| </header> | ||
| <span class="banner" id="skyBanner"></span> | ||
| <section class="cityNameBlock"> |
There was a problem hiding this comment.
Consider refactoring your class names so that they are lowercase and hyphenated between words
<h1 id="site-title">The Weather Station</h1>
Comment on lines
+62
to
+69
| const cityName = document.querySelector('#cityName'); | ||
| const inputContainer = document.querySelector('#inputCityName'); | ||
| state.city = inputContainer.value; | ||
| cityName.textContent = state.city; | ||
| }; | ||
|
|
||
| const resetCityName = (event) => { | ||
| const cityName = document.querySelector('#cityName'); |
There was a problem hiding this comment.
Looks like we are repeating code on lines 62 and 69! Maybe we can create global variables that will hold elements like this that will be used more than once
Comment on lines
+78
to
+102
| axios | ||
| .get(`http://localhost:5000/location?q=${state.city}`) | ||
| .then((response) => { | ||
| state.latitude = response.data[0].lat; | ||
| state.longitude = response.data[0].lon; | ||
| console.log(response.data); | ||
| axios | ||
| .get( | ||
| `http://localhost:5000/weather?lat=${state.latitude}&lon=${state.longitude}` | ||
| ) | ||
| .then((response) => { | ||
| const temperatureKelvin = response.data.main.temp; | ||
| state.Temperature = ((temperatureKelvin - 273.15) * 9) / 5 + 32; | ||
| tempContainer.textContent = `${Math.round(state.Temperature)}`; | ||
| tempRange(); | ||
| console.log(response.data); | ||
| }) | ||
| .catch((error) => { | ||
| console.log('OpenWeather GET request error'); | ||
| }); | ||
| }) | ||
| .catch((error) => { | ||
| console.log('LocationIQ GET request error'); | ||
| }); | ||
| }; |
There was a problem hiding this comment.
good indentation! makes the promises easier to read 👍
Comment on lines
+28
to
+44
| if (state.Temperature >= 80) { | ||
| tempContainer.style.color = 'red'; | ||
| landscapeContainer.textContent = '🌵__🐍_🦂_🌵🌵__🐍_🏜_🦂'; | ||
| } else if (state.Temperature <= 79 && state.Temperature >= 70) { | ||
| tempContainer.style.color = 'orange'; | ||
| landscapeContainer.textContent = '🌸🌿🌼__🌷🌻🌿_☘️🌱_🌻🌷'; | ||
| } else if (state.Temperature <= 69 && state.Temperature >= 60) { | ||
| tempContainer.style.color = 'yellow'; | ||
| landscapeContainer.textContent = '🌾🌾_🍃_🪨__🛤_🌾🌾🌾_🍃'; | ||
| } else if (state.Temperature <= 59 && state.Temperature >= 50) { | ||
| tempContainer.style.color = 'green'; | ||
| landscapeContainer.textContent = '🌲🌲⛄️🌲⛄️🍂🌲🍁🌲🌲⛄️🍂🌲'; | ||
| } else if (state.Temperature <= 49) { | ||
| tempContainer.style.color = 'teal'; | ||
| landscapeContainer.textContent = '🌲🌲⛄️🌲⛄️🍂🌲🍁🌲🌲⛄️🍂🌲'; | ||
| } | ||
| }; |
There was a problem hiding this comment.
How might you refactor this so the logic is more data driven? Here you have several if/else if statements. What if you had an object with the keys as the temperature and the values as the landscape and temperature corresponding display? Then you could iterate over the object to set state!
It could look something like this:
const tempColors = [
[49, 'blue'],
[59, 'green'],
[69, 'gold'],
[79, 'orange'],
[null, 'red'],
];
const getColorForTemp = (temp) => {
for (const [boundaryTemp, color] of tempColors) {
if (boundaryTemp === null || temp <= boundaryTemp) {
return color;
}
}
};| @@ -0,0 +1,98 @@ | |||
| body { | |||
| display: grid; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.