small updates to Colab demo #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MMathisLab
commented
May 15, 2024
MMathisLab
commented
- file naming consistency
- file path; otherwise it would not run for me:
-remove unnecessary descriptions; as it takes up horizontal space in Colab and reduces the visibility of the code.
|
Thanks @MMathisLab ! I will have a look and merge soon. |
C-Achard
reviewed
May 16, 2024
notebooks/Colab_inference_demo.ipynb
Outdated
| }, | ||
| "source": [ | ||
| "<a href=\"https://colab.research.google.com/github/AdaptiveMotorControlLab/CellSeg3d/blob/main/notebooks/colab_inference_demo.ipynb\" target=\"_parent\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" alt=\"Open In Colab\"/></a>" | ||
| "<a href=\"https://colab.research.google.com/github/MMathisLab/CellSeg3d/blob/main/notebooks/Colab_inference_demo.ipynb\" target=\"_parent\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" alt=\"Open In Colab\"/></a>" |
There was a problem hiding this comment.
Let's just make sure the URL is not a problem before merging, we might have to change it
There was a problem hiding this comment.
def. can change, agree
| "# @title Load demo image and inference configuration\n", | ||
| "#@markdown This cell loads a demo image and load the inference configuration.\n", | ||
| "demo_image_path = \"./CellSeg3D/examples/c5image.tif\n", | ||
| "demo_image_path = \"/content/CellSeg3D/examples/c5image.tif\"\n", |
There was a problem hiding this comment.
I'll check again before merging
C-Achard
approved these changes
May 28, 2024
|
All good, merging now, thanks again @MMathisLab (and sorry for the delay) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.