-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DNS rebinding protection #2397
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2397 +/- ##
==========================================
+ Coverage 38.14% 38.67% +0.52%
==========================================
Files 84 85 +1
Lines 9593 9723 +130
==========================================
+ Hits 3659 3760 +101
- Misses 5475 5498 +23
- Partials 459 465 +6
Continue to review full report at Codecov.
|
Wow that's massive, thank you! |
Great, but there is a need to add some logic to handle the new DNS rebinding protection request in the query log correctly |
@ArtemBaskal could you give some pointers on what's missing specifically? Thanks for reviewing. |
@juniorz the problem is that this new status is not handled by the query log.
|
But what is the difference?
Hi @ameshkov , thank you for the feedback. I believe I have found my way through the stats and logging subsystems and I was able to make the requests blocked to be displayed to the end-user. Could you please review and provide feedback on the choice of colors/categorization? Responses blocked due to DNS rebinding attempts will contribute to "Blocked by Filters" stats, and in the logs, they are in the "Filtered" category - but I have also added a "Blocked rebinding" category. |
Also, lint failed but the Github check does not give any meaningful output so I don't really know what needs to be fixed. And running |
@juniorz got it, thank you! We'll take care of it |
When will this be merged? |
The implementation of IP blocking is based on
dnsmasq
in regard to which CIDRs to block.Closes #102