Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Mockito inline dependency #3328

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

add Mockito inline dependency #3328

wants to merge 1 commit into from

Conversation

MikhailNavitski
Copy link
Contributor

@kwin
Copy link
Contributor

kwin commented Apr 18, 2024

Why adding a new dependency without changing any code? What does this fix?

@MikhailNavitski
Copy link
Contributor Author

Why adding a new dependency without changing any code? What does this fix?

Currently, there are several open issues related to the unit tests that I am planning to work on ( as an example #2279). There is no possibility to mock static methods right now, so, it fixes that issue
and I can proceed with the #2279

@MikhailNavitski
Copy link
Contributor Author

But It seems like need to rewrite a ton of tests for it :)

@MikhailNavitski MikhailNavitski force-pushed the feature/mockito-inline branch 2 times, most recently from d422732 to 575d6fd Compare April 20, 2024 00:24
@MikhailNavitski MikhailNavitski marked this pull request as draft April 20, 2024 00:40
@MikhailNavitski MikhailNavitski force-pushed the feature/mockito-inline branch 2 times, most recently from 62dc6c1 to aa64f65 Compare April 21, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikhailNavitski @kwin