Removed some Felix SCR annotations and replaced with OSGi annotations #3332
Conversation
davidjgonzalez
changed the title
| import org.apache.sling.api.SlingHttpServletRequest; | ||
| import org.osgi.framework.ServiceRegistration; | ||
| import org.osgi.service.component.ComponentContext; | ||
| import org.osgi.service.component.annotations.Deactivate; |
There was a problem hiding this comment.
Because this is a public abstract class, I recommend leaving the SCR annotation in place here, in addition to the DS annotation, so that consumers using Felix SCR tooling will still find the old annotation in the class file.
| @@ -38,6 +38,8 @@ | |||
| import org.osgi.framework.ServiceReference; | |||
| import org.osgi.framework.ServiceRegistration; | |||
| import org.osgi.service.component.ComponentContext; | |||
| import org.osgi.service.component.annotations.Activate; | |||
There was a problem hiding this comment.
Because this is a public abstract class, I recommend leaving the SCR annotation in place here, in addition to the DS annotation, so that consumers using Felix SCR tooling will still find the old annotation in the class file.
There was a problem hiding this comment.
Yes, exactly. As in:
@Activate
@org.apache.felix.scr.annotations.Activate
protected void activate() {
}
Any customers with components that extend from these classes without overriding the annotated method would still have to be using SCR annotations. (Using DS component inheritance is discouraged, but it is supported by default with maven-bundle-plugin when using SCR annotations).
There was a problem hiding this comment.
I wouldn’t consider such edge cases. Too much maintenance overhead and easy to fix on consumer side.
bundle/src/main/java/com/adobe/acs/commons/packaging/impl/ACLPackagerServletImpl.java
Outdated
Show resolved
Hide resolved
davidjgonzalez
added
the
Skip-Changelog
Didnt do the components that require OCDs:
Remaining