Remove forced theme from new system notifications #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: |
scotty6435
changed the title
The forced theme sets a red background for other theme colours. Testing locally with all theme colours worked fine with this CSS removed.
scotty6435
force-pushed
the
defect/system-notifications/use-natural-theme-colour
branch
from
650a21a
to
54a04c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently amended system notifications dialog has been re-styles using CoralUI 3 elements but for some reason a hardcoded red theme was applied to the content area.
In local testing, all alert themes set appropriate colours when this CSS was removed. I can't find a reference to why this was added, maybe it was required only for an earlier version of the code before the themes were implemented?