Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend header to match checkstyle format #3382

Conversation

scotty6435
Copy link
Contributor

@scotty6435 scotty6435 commented Jul 12, 2024

The checkstyle code status on this project has 1,634 issues, mostly because of one rule violation. Checkstyle compares the Java header to .codeclimate/header.txt but because " Bundle" is omitted, none of these match. I've updated the header on all java files for the main bundle but have not touched a few references in oakpal-checks. Please let me know if you want to add a qualifier to any of these and I can amend e.g. "ACS AEM Commons Oakpal Checks Bundle".

The pattern:

 ?\* ACS AEM Commons[A-Za-z ]* Bundle

Build status showing the issue mixed with other minor Checkstyle issues:
https://codeclimate.com/github/Adobe-Consulting-Services/acs-aem-commons/issues?status%5B%5D=&engine_name%5B%5D=checkstyle

The proper header template file has also been applied across the whole bundle to standardise optional lines, add copyright start dates, remove rogue characters and to fix spacing between the header and the package line.

@scotty6435 scotty6435 force-pushed the defect/checkstyle-comment-issues branch from 86465c6 to 17b3c31 Compare July 12, 2024 11:33
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.56%. Comparing base (7676ed5) to head (1d6d105).
Report is 20 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3382      +/-   ##
============================================
+ Coverage     55.34%   55.56%   +0.21%     
- Complexity     5543     5582      +39     
============================================
  Files           728      728              
  Lines         29705    29798      +93     
  Branches       3875     3887      +12     
============================================
+ Hits          16440    16557     +117     
+ Misses        11722    11688      -34     
- Partials       1543     1553      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scotty6435 scotty6435 closed this Aug 8, 2024
@scotty6435 scotty6435 force-pushed the defect/checkstyle-comment-issues branch from 1d6d105 to b10cfa8 Compare August 8, 2024 14:24
@scotty6435
Copy link
Contributor Author

Doesn't look like this is progressing, since I really don't want 10 million conflicts to resolve this has been closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant