Hide default pay button configuration #1701

nauaros · 2024-05-30T14:09:43Z

Summary

Define configuration property to show/hide default submit button.
Add logic to add / remove scroll view from the view hierarchy based on the submit button configuration.
Apply submit button configuration to all required components.
Build advanced card component flow to showcase / QA submit button configuration.

…-configuration

…ntroller

github-actions

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

erenbesel

Great start, just small comments!

Adyen/UI/Form/FormViewController.swift

AdyenCard/Components/Card/CardComponent.swift

…-configuration

Adyen/UI/Form/FormViewController.swift

Adyen/Core/Components/Base/BasicComponentConfiguration.swift

Adyen/Core/Components/StoredPaymentMethodComponent.swift

Adyen/UI/Form/FormView.swift

Adyen/UI/Form/FormViewController.swift

atmamont · 2024-06-14T12:54:32Z

I will do manual testing on Monday.

atmamont · 2024-06-19T08:02:46Z

Should this one have new label and a corresponding release notes? Some merchants would be really happy to get this feature.

…-configuration

Adyen/UI/Form/FormView.swift

AdyenCard/Components/Card/CardComponent.swift

…-configuration

Regenerate snapshots Co-authored-by: nauaros <10688366+nauaros@users.noreply.github.com>

github-actions · 2024-07-12T09:11:19Z

👀 27 public changes detected

Comparing https://github.com/Adyen/adyen-ios.git @ hide-pay-button-configuration to https://github.com/Adyen/adyen-ios.git @ COIOS-382_Configurable_pay_button

`Adyen`

`BasicComponentConfiguration`

😶‍🌫️ public func init(style: Adyen.FormComponentStyle, localizationParameters: Adyen.LocalizationParameters?) -> Adyen.BasicComponentConfiguration was removed
❇️ public func init(style: Adyen.FormComponentStyle, showSubmitButton: Swift.Bool, localizationParameters: Adyen.LocalizationParameters?) -> Adyen.BasicComponentConfiguration was added
❇️ public var showSubmitButton: Swift.Bool { get } was added

`PersonalInformationConfiguration`

😶‍🌫️ public func init(style: Adyen.FormComponentStyle, shopperInformation: Adyen.PrefilledShopperInformation?, localizationParameters: Adyen.LocalizationParameters?) -> Adyen.PersonalInformationConfiguration was removed
❇️ public func init(style: Adyen.FormComponentStyle, showSubmitButton: Swift.Bool, shopperInformation: Adyen.PrefilledShopperInformation?, localizationParameters: Adyen.LocalizationParameters?) -> Adyen.PersonalInformationConfiguration was added
❇️ public var showSubmitButton: Swift.Bool { get } was added

`StoredPaymentMethodComponent.Configuration`

😶‍🌫️ public func init(localizationParameters: Adyen.LocalizationParameters?) -> Adyen.StoredPaymentMethodComponent.Configuration was removed
❇️ public func init(showSubmitButton: Swift.Bool, localizationParameters: Adyen.LocalizationParameters?) -> Adyen.StoredPaymentMethodComponent.Configuration was added
❇️ public var showSubmitButton: Swift.Bool { get } was added

`AdyenCard`

`CardComponent`

❇️ public func submit() -> Void was added

`CardComponent.Configuration`

😶‍🌫️ public func init(style: Adyen.FormComponentStyle, shopperInformation: Adyen.PrefilledShopperInformation?, localizationParameters: Adyen.LocalizationParameters?, showsHolderNameField: Swift.Bool, showsStorePaymentMethodField: Swift.Bool, showsSecurityCodeField: Swift.Bool, koreanAuthenticationMode: AdyenCard.CardComponent.FieldVisibility, socialSecurityNumberMode: AdyenCard.CardComponent.FieldVisibility, storedCardConfiguration: AdyenCard.StoredCardConfiguration, allowedCardTypes: [Adyen.CardType]?, installmentConfiguration: Adyen.InstallmentConfiguration?, billingAddress: AdyenCard.BillingAddressConfiguration) -> AdyenCard.CardComponent.Configuration was removed
❇️ public func init(style: Adyen.FormComponentStyle, showSubmitButton: Swift.Bool, shopperInformation: Adyen.PrefilledShopperInformation?, localizationParameters: Adyen.LocalizationParameters?, showsHolderNameField: Swift.Bool, showsStorePaymentMethodField: Swift.Bool, showsSecurityCodeField: Swift.Bool, koreanAuthenticationMode: AdyenCard.CardComponent.FieldVisibility, socialSecurityNumberMode: AdyenCard.CardComponent.FieldVisibility, storedCardConfiguration: AdyenCard.StoredCardConfiguration, allowedCardTypes: [Adyen.CardType]?, installmentConfiguration: Adyen.InstallmentConfiguration?, billingAddress: AdyenCard.BillingAddressConfiguration) -> AdyenCard.CardComponent.Configuration was added
❇️ public var showSubmitButton: Swift.Bool { get } was added

`GiftCardComponent`

❇️ public func init(paymentMethod: Adyen.GiftCardPaymentMethod, context: Adyen.AdyenContext, amount: Adyen.Amount, style: Adyen.FormComponentStyle, showSubmitButton: Swift.Bool, showsSecurityCodeField: Swift.Bool) -> AdyenCard.GiftCardComponent was added
😶‍🌫️ public func init(paymentMethod: Adyen.GiftCardPaymentMethod, context: Adyen.AdyenContext, amount: Adyen.Amount, style: Adyen.FormComponentStyle, showsSecurityCodeField: Swift.Bool) -> AdyenCard.GiftCardComponent was removed
❇️ public func init(paymentMethod: Adyen.MealVoucherPaymentMethod, context: Adyen.AdyenContext, amount: Adyen.Amount, style: Adyen.FormComponentStyle, showSubmitButton: Swift.Bool, showsSecurityCodeField: Swift.Bool) -> AdyenCard.GiftCardComponent was added
😶‍🌫️ public func init(paymentMethod: Adyen.MealVoucherPaymentMethod, context: Adyen.AdyenContext, amount: Adyen.Amount, style: Adyen.FormComponentStyle, showsSecurityCodeField: Swift.Bool) -> AdyenCard.GiftCardComponent was removed
❇️ public var showSubmitButton: Swift.Bool { get } was added

`AdyenCashAppPay`

`CashAppPayConfiguration`

😶‍🌫️ public func init(redirectURL: Foundation.URL, referenceId: Swift.String?, showsStorePaymentMethodField: Swift.Bool, storePaymentMethod: Swift.Bool, style: Adyen.FormComponentStyle, localizationParameters: Adyen.LocalizationParameters?) -> AdyenCashAppPay.CashAppPayConfiguration was removed
❇️ public func init(redirectURL: Foundation.URL, referenceId: Swift.String?, showsStorePaymentMethodField: Swift.Bool, storePaymentMethod: Swift.Bool, style: Adyen.FormComponentStyle, showSubmitButton: Swift.Bool, localizationParameters: Adyen.LocalizationParameters?) -> AdyenCashAppPay.CashAppPayConfiguration was added
❇️ public var showSubmitButton: Swift.Bool { get } was added

`AdyenComponents`

`ACHDirectDebitComponent.Configuration`

😶‍🌫️ public func init(style: Adyen.FormComponentStyle, shopperInformation: Adyen.PrefilledShopperInformation?, localizationParameters: Adyen.LocalizationParameters?, showsStorePaymentMethodField: Swift.Bool, showsBillingAddress: Swift.Bool, billingAddressCountryCodes: [Swift.String]) -> AdyenComponents.ACHDirectDebitComponent.Configuration was removed
❇️ public func init(style: Adyen.FormComponentStyle, showSubmitButton: Swift.Bool, shopperInformation: Adyen.PrefilledShopperInformation?, localizationParameters: Adyen.LocalizationParameters?, showsStorePaymentMethodField: Swift.Bool, showsBillingAddress: Swift.Bool, billingAddressCountryCodes: [Swift.String]) -> AdyenComponents.ACHDirectDebitComponent.Configuration was added
❇️ public var showSubmitButton: Swift.Bool { get } was added

`BoletoComponent.Configuration`

😶‍🌫️ public func init(style: Adyen.FormComponentStyle, localizationParameters: Adyen.LocalizationParameters?, shopperInformation: Adyen.PrefilledShopperInformation?, showEmailAddress: Swift.Bool) -> AdyenComponents.BoletoComponent.Configuration was removed
❇️ public func init(style: Adyen.FormComponentStyle, showSubmitButton: Swift.Bool, localizationParameters: Adyen.LocalizationParameters?, shopperInformation: Adyen.PrefilledShopperInformation?, showEmailAddress: Swift.Bool) -> AdyenComponents.BoletoComponent.Configuration was added
❇️ public var showSubmitButton: Swift.Bool { get } was added

Analyzed modules: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay

sonarcloud · 2024-07-12T09:25:07Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

nauaros added 15 commits May 9, 2024 17:03

Use card component within non scrollable container view

4ff6a62

Use card component within non scrollable container view

cca1993

Update

62ba38a

Update publish job

1db89df

Merge branch 'develop' into remove-pay-button-research

51342ab

Form view changes

32e49b1

Merge branch 'COIOS-382_Configurable_pay_button' into hide-pay-button…

41d81e8

…-configuration

Define hide pay button property

0016ff2

Expose function to trigger payment

53d302f

Rename hidePayButton property

6d35ab2

Remove UIScrollView from FormView

f7a8f61

Add UIScrollView to UIFormViewController

a0fb9c4

Update form view constrains

5d3fedf

Refactor FormView

c7e5aa4

Add logic to add/remove scroll view from view hierarchy in FormViewCo…

8bbcced

…ntroller

github-actions bot requested changes May 30, 2024

View reviewed changes

Update showing/hiding pay button logic

903cfad

erenbesel reviewed May 31, 2024

View reviewed changes

Adyen/UI/Form/FormViewController.swift Outdated Show resolved Hide resolved

Adyen/UI/Form/FormViewController.swift Outdated Show resolved Hide resolved

Adyen/UI/Form/FormViewController.swift Show resolved Hide resolved

Adyen/UI/Form/FormViewController.swift Outdated Show resolved Hide resolved

nauaros added 5 commits June 5, 2024 13:35

Add hide pay button flag to CashAppComponent

66cbfc0

Add hide default pay button flag to GiftCardComponent

d6d9811

Align hide/show pay button with web team

0b84cf9

Rename showDefaultPayButton to showSubmitButton

8c654d1

Update configurable pay button demo with new APIs

8f8cf00

nauaros commented Jun 10, 2024

View reviewed changes

AdyenCard/Components/Card/CardComponent.swift Show resolved Hide resolved

Delete logic in didUpdatePreferredContentSize method

d973253

nauaros marked this pull request as ready for review June 11, 2024 11:55

nauaros added the new a pull request that adds a new feature label Jun 11, 2024

github-actions bot approved these changes Jun 11, 2024

View reviewed changes

nauaros added 2 commits June 13, 2024 11:12

Refactor layout method

febb1d9

Update compile error in tests suite

c84f3a0

Merge branch 'COIOS-382_Configurable_pay_button' into hide-pay-button…

3de4c07

…-configuration

goergisn requested a review from erenbesel June 13, 2024 11:40

goergisn reviewed Jun 13, 2024

View reviewed changes

Adyen/UI/Form/FormViewController.swift Show resolved Hide resolved

nauaros added 4 commits June 13, 2024 16:40

Apply styling to FormViewController

b510001

Add missing styling

81c849f

Logic to calc intrinsic content size based on scrolling behavior

a11e550

Enabled scrolling in FormView for PreSelectedPaymentMethod

18646d7

atmamont approved these changes Jun 14, 2024

View reviewed changes

nauaros added 4 commits June 14, 2024 15:28

Make scrollView property lazy

cfff590

Make set private for showSubmitButton property

b347271

Update header in FormView

39ec8c5

Refactor layout code in FormViewController

84cc79c

nauaros added 4 commits June 24, 2024 12:48

Merge branch 'COIOS-382_Configurable_pay_button' into hide-pay-button…

9f19190

…-configuration

Fix scrolling bug in drop-in components

9020c8e

Enabled CashApp Pay by default

ba23c4e

Disable alert when drop-in flow is cancelled

490e84d

descorp reviewed Jun 27, 2024

View reviewed changes

Adyen/UI/Form/FormView.swift Show resolved Hide resolved

descorp reviewed Jun 27, 2024

View reviewed changes

Adyen/UI/Form/FormView.swift Show resolved Hide resolved

erenbesel reviewed Jun 27, 2024

View reviewed changes

AdyenCard/Components/Card/CardComponent.swift Show resolved Hide resolved

descorp reviewed Jun 27, 2024

View reviewed changes

AdyenCard/Components/Card/CardComponent.swift Show resolved Hide resolved

nauaros and others added 4 commits July 11, 2024 14:57

Merge branch 'COIOS-382_Configurable_pay_button' into hide-pay-button…

f5002ef

…-configuration

Generate snapshots

3af5bb5

Merge branch 'COIOS-382_Configurable_pay_button' into hide-pay-button…

c6f66a3

…-configuration

🤖 Generate Snapshots (#1743)

8131651

Regenerate snapshots Co-authored-by: nauaros <10688366+nauaros@users.noreply.github.com>

nauaros merged commit 9221d73 into COIOS-382_Configurable_pay_button Jul 12, 2024
10 checks passed

nauaros deleted the hide-pay-button-configuration branch July 12, 2024 09:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide default pay button configuration #1701

Hide default pay button configuration #1701

nauaros commented May 30, 2024 •

edited

Loading

github-actions bot left a comment

erenbesel left a comment

atmamont commented Jun 14, 2024

atmamont commented Jun 19, 2024

github-actions bot commented Jul 12, 2024

sonarcloud bot commented Jul 12, 2024

Hide default pay button configuration #1701

Hide default pay button configuration #1701

Conversation

nauaros commented May 30, 2024 • edited Loading

Summary

github-actions bot left a comment

Choose a reason for hiding this comment

erenbesel left a comment

Choose a reason for hiding this comment

atmamont commented Jun 14, 2024

atmamont commented Jun 19, 2024

github-actions bot commented Jul 12, 2024

👀 27 public changes detected

Adyen

BasicComponentConfiguration

PersonalInformationConfiguration

StoredPaymentMethodComponent.Configuration

AdyenCard

CardComponent

CardComponent.Configuration

GiftCardComponent

AdyenCashAppPay

CashAppPayConfiguration

AdyenComponents

ACHDirectDebitComponent.Configuration

BoletoComponent.Configuration

sonarcloud bot commented Jul 12, 2024

Quality Gate passed

nauaros commented May 30, 2024 •

edited

Loading

`Adyen`

`BasicComponentConfiguration`

`PersonalInformationConfiguration`

`StoredPaymentMethodComponent.Configuration`

`AdyenCard`

`CardComponent`

`CardComponent.Configuration`

`GiftCardComponent`

`AdyenCashAppPay`

`CashAppPayConfiguration`

`AdyenComponents`

`ACHDirectDebitComponent.Configuration`

`BoletoComponent.Configuration`