Delegated authentication - with newer screens #1726

robertdalmeida · 2024-06-24T11:59:44Z

Support for delegated authentication

Summary

Delegated authentication screens

create authentication sdk release.
Ready to merge

Register

Register.mp4

Approval

Approve.mp4

Delete

Delete.mp4

Registration Error

Register_Error.mp4

Error on approve

Approve_error.mp4

Adjust the spacing of the views and fonts of the title Update the copies Adjust spacing Remove the green background

…adyen-ios into delegated-authentication-passkeys

...nts/3DS2/Action handlers/3DS2+Delegated Authentication/ThreeDS2PlusDACoreActionHandler.swift

AdyenActions/UI/View Controllers/DelegatedAuthentication/ViewHelpers/UIStackViewHelper.swift

Scripts/test-SPM-integration.sh

Scripts/test-CocoaPods-integration.sh

.github/workflows/test_cocoapods_integration.yml

erenbesel

Thanks a lot Robert! Approved with a tiny suggestion

AdyenActions/UI/View Controllers/DelegatedAuthentication/DAApprovalViewController.swift

…hentication).

github-actions · 2024-07-22T14:13:01Z

👀 13 public changes detected

Comparing https://github.com/Adyen/adyen-ios.git @ delegated-authentication-passkeys to https://github.com/Adyen/adyen-ios.git @ develop

`AdyenActions`

❇️ import LocalAuthentication was added
❇️ public struct DelegatedAuthenticationComponentStyle was added

`ActionComponentStyle`

😶‍🌫️ public func init(redirectComponentStyle: AdyenActions.RedirectComponentStyle, awaitComponentStyle: AdyenActions.AwaitComponentStyle, voucherComponentStyle: AdyenActions.VoucherComponentStyle, qrCodeComponentStyle: AdyenActions.QRCodeComponentStyle, documentActionComponentStyle: AdyenActions.DocumentComponentStyle) -> AdyenActions.ActionComponentStyle was removed
❇️ public func init(redirectComponentStyle: AdyenActions.RedirectComponentStyle, awaitComponentStyle: AdyenActions.AwaitComponentStyle, voucherComponentStyle: AdyenActions.VoucherComponentStyle, qrCodeComponentStyle: AdyenActions.QRCodeComponentStyle, documentActionComponentStyle: AdyenActions.DocumentComponentStyle, delegatedAuthenticationComponentStyle: AdyenActions.DelegatedAuthenticationComponentStyle) -> AdyenActions.ActionComponentStyle was added
❇️ public var delegatedAuthenticationComponentStyle: AdyenActions.DelegatedAuthenticationComponentStyle { get set } was added

`ThreeDS2Component.Configuration.DelegatedAuthentication`

😶‍🌫️ public func init(localizedRegistrationReason: Swift.String, localizedAuthenticationReason: Swift.String, appleTeamIdentifier: Swift.String) -> AdyenActions.ThreeDS2Component.Configuration.DelegatedAuthentication was removed
❇️ public func init(relyingPartyIdentifier: Swift.String, delegatedAuthenticationComponentStyle: AdyenActions.DelegatedAuthenticationComponentStyle, localizationParameters: Adyen.LocalizationParameters?) -> AdyenActions.ThreeDS2Component.Configuration.DelegatedAuthentication was added
😶‍🌫️ public let appleTeamIdentifier: Swift.String { get } was removed
❇️ public let delegatedAuthenticationComponentStyle: AdyenActions.DelegatedAuthenticationComponentStyle { get } was added
❇️ public let localizationParameters: Adyen.LocalizationParameters? { get } was added
😶‍🌫️ public let localizedAuthenticationReason: Swift.String { get } was removed
😶‍🌫️ public let localizedRegistrationReason: Swift.String { get } was removed
❇️ public let relyingPartyIdentifier: Swift.String { get } was added

Analyzed modules: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay

erenbesel

🎉

sonarcloud · 2024-07-22T14:24:08Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.2% Coverage on New Code
2.6% Duplication on New Code

See analysis details on SonarCloud

robertdalmeida added the changed a pull request that changed some thing label Jun 24, 2024

robertdalmeida self-assigned this Jun 24, 2024

github-actions bot previously approved these changes Jun 24, 2024

View reviewed changes

robertdalmeida dismissed github-actions’s stale review via 4b8d148 July 1, 2024 21:47

github-actions bot previously approved these changes Jul 1, 2024

View reviewed changes

robertdalmeida dismissed github-actions’s stale review via 20dde5e July 1, 2024 21:59

github-actions bot previously approved these changes Jul 1, 2024

View reviewed changes

robertdalmeida dismissed github-actions’s stale review via a361ce6 July 1, 2024 22:20

github-actions bot previously approved these changes Jul 1, 2024

View reviewed changes

Implementing da with passkey

cb5622a

Adjust the spacing of the views and fonts of the title Update the copies Adjust spacing Remove the green background

robertdalmeida force-pushed the delegated-authentication-passkeys branch from 332a294 to cb5622a Compare July 1, 2024 22:23

Don't show close button for the DA screens

db20dd7

robertdalmeida dismissed github-actions’s stale review via db20dd7 July 1, 2024 22:37

github-actions bot previously approved these changes Jul 1, 2024

View reviewed changes

robertdalmeida requested review from mohammedDehairy, goergisn and erenbesel July 2, 2024 12:58

cleaned the public interface

6f57c02

robertdalmeida dismissed github-actions’s stale review via 6f57c02 July 2, 2024 13:18

github-actions bot previously approved these changes Jul 2, 2024

View reviewed changes

goergisn and others added 3 commits July 3, 2024 14:53

Merge branch 'develop' into delegated-authentication-passkeys

5d7c932

Remove the hardcoded values of the card details

8b6819b

Merge branch 'delegated-authentication-passkeys' of github.com:Adyen/…

7a321b1

…adyen-ios into delegated-authentication-passkeys

robertdalmeida dismissed github-actions’s stale review via 7a321b1 July 3, 2024 20:57

github-actions bot previously approved these changes Jul 3, 2024

View reviewed changes

goergisn previously approved these changes Jul 4, 2024

View reviewed changes

...nts/3DS2/Action handlers/3DS2+Delegated Authentication/ThreeDS2PlusDACoreActionHandler.swift Show resolved Hide resolved

...nts/3DS2/Action handlers/3DS2+Delegated Authentication/ThreeDS2PlusDACoreActionHandler.swift Show resolved Hide resolved

Adyen deleted a comment from github-actions bot Jul 4, 2024

Making some completion levels smaller by splitting into methods

ca4f30e

robertdalmeida dismissed goergisn’s stale review via ca4f30e July 4, 2024 14:37

robertdalmeida dismissed github-actions’s stale review via 42072ac July 12, 2024 14:23

github-actions bot previously approved these changes Jul 12, 2024

View reviewed changes

Avoid using DispatchWorkItem

b0039d2

robertdalmeida dismissed github-actions’s stale review via b0039d2 July 13, 2024 21:23

github-actions bot previously approved these changes Jul 13, 2024

View reviewed changes

robertdalmeida requested a review from erenbesel July 15, 2024 10:01

goergisn reviewed Jul 16, 2024

View reviewed changes

Remove an unused else condition

a36dfd5

robertdalmeida dismissed github-actions’s stale review via a36dfd5 July 16, 2024 21:04

github-actions bot previously approved these changes Jul 16, 2024

View reviewed changes

robertdalmeida and others added 2 commits July 18, 2024 08:52

Merge branch 'develop' into delegated-authentication-passkeys

8ec43ed

Merge branch 'develop' into delegated-authentication-passkeys

5bed290

goergisn self-requested a review July 22, 2024 12:10

goergisn previously approved these changes Jul 22, 2024

View reviewed changes

erenbesel previously approved these changes Jul 22, 2024

View reviewed changes

AdyenActions/UI/View Controllers/DelegatedAuthentication/DAApprovalViewController.swift Outdated Show resolved Hide resolved

Fix review comment to move Handler to a more broader scope

3b1fc90

robertdalmeida dismissed stale reviews from erenbesel, goergisn, and github-actions via 3b1fc90 July 22, 2024 13:03

github-actions bot previously approved these changes Jul 22, 2024

View reviewed changes

Increase the scope of the typealias beyond the #if canimport(AdyenAut…

33e8a18

…hentication).

robertdalmeida dismissed github-actions’s stale review via 33e8a18 July 22, 2024 13:58

github-actions bot approved these changes Jul 22, 2024

View reviewed changes

erenbesel approved these changes Jul 22, 2024

View reviewed changes

goergisn self-requested a review July 22, 2024 14:35

goergisn approved these changes Jul 22, 2024

View reviewed changes

robertdalmeida merged commit b7fdab3 into develop Jul 22, 2024
12 checks passed

robertdalmeida deleted the delegated-authentication-passkeys branch July 22, 2024 19:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delegated authentication - with newer screens #1726

Delegated authentication - with newer screens #1726

robertdalmeida commented Jun 24, 2024 •

edited

Loading

erenbesel left a comment

github-actions bot commented Jul 22, 2024

erenbesel left a comment

sonarcloud bot commented Jul 22, 2024

Delegated authentication - with newer screens #1726

Delegated authentication - with newer screens #1726

Conversation

robertdalmeida commented Jun 24, 2024 • edited Loading

Summary

Register

Approval

Delete

Registration Error

Error on approve

erenbesel left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 22, 2024

👀 13 public changes detected

AdyenActions

ActionComponentStyle

ThreeDS2Component.Configuration.DelegatedAuthentication

erenbesel left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jul 22, 2024

Quality Gate passed

robertdalmeida commented Jun 24, 2024 •

edited

Loading

`AdyenActions`

`ActionComponentStyle`

`ThreeDS2Component.Configuration.DelegatedAuthentication`