-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/v5 card adds analytics config data #2724
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata for the (Custom)Card comp
…esented in configData as a boolean
… callback functions have been defined
…s now ready to be sent in
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
June 24, 2024 14:22
🦋 Changeset detectedLatest commit: 51d4251 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +5.15 kB (+0.44%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
longyulongyu
approved these changes
Jul 19, 2024
Quality Gate passedIssues Measures |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a
configData
object to theinfo
event (type:'rendered')
for/checkoutanalytics
This object will contain details of the configuration that the component has been set up with.
We're starting out with the config for the
Card
component, but will later expand it toDropin
, other components and even some of the top levelCheckout
configurationTested scenarios
Unit tests added for the generation of card related
configData
Relates to issue: COWEB-1351 (checkoutanalytics mvp)