Installments component shows a translatable label above its fields #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: 045bb62 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +414 B (+0.04%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
…take the form of a dropdown
…take the form of a radiogroup
…reaking Riverty & CtP unit tests
…Riverty's readonly deliveryAddress
…aria-label on the RadioGroup element
|
m1aw
approved these changes
Jul 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Installments component was incorrectly set up.
It should always show a label with translatable text above it's radio button (or dropdown) elements.
In one case (dropdown) we were retrieving the label but not displaying it. In the other case (radio button group) we were never even creating the labelling element.
This PR fixes that
Tested scenarios
Manually tested that the label shows up in both cases.
Added new condition to existing unit test
All existing unit tests pass
Fixed issue: #2609