Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

200 move to pnpm #220

Conversation

joao-m-santos
Copy link
Contributor

Relates to #200

📝 Description

Switch from npm + nx to pnpm in order to fix Storybook's dependency problems and the fact that npm doesn't support not hoisting dependencies.

Context:

Findings:

  • pnpm works faster, especially in a Docker container
  • Dependencies declared in package.json are better-structured - fully scoped for each workspace
  • pnpm allows for running commands in parallel, plus its great workspaces support removes need for nx, thus reducing architecture complexity

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

This PR is only to be merged after a decision is made between pnpm and yarn. Until then it serves as an example of the pnpm implementation in the existing project.

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@joao-m-santos joao-m-santos self-assigned this Jun 20, 2023
@joao-m-santos
Copy link
Contributor Author

Closed by #257

@joao-m-santos joao-m-santos deleted the 200-move-to-pnpm branch September 25, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant