Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve/refactor alluvial code #235

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Improve/refactor alluvial code #235

merged 2 commits into from
Aug 31, 2023

Conversation

joao-m-santos
Copy link
Contributor

@joao-m-santos joao-m-santos commented Jul 10, 2023 •
edited
Loading

Closes #234

📝 Description

  • Removed the need for generateLinkId by setting it in the initial links mapping
  • Fixed gradient generation for deriveColorFromIncomingLinks with gradient: true

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@joao-m-santos joao-m-santos self-assigned this Jul 10, 2023
@netlify
Copy link

netlify bot commented Jul 10, 2023 •
edited
Loading

✅ Deploy Preview for adyen-lume ready!

Name Link
🔨 Latest commit 0a4348e
🔍 Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/64f0a7bfefcf320008126232
😎 Deploy Preview https://deploy-preview-235--adyen-lume.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joao-m-santos joao-m-santos marked this pull request as ready for review August 4, 2023 13:36
@joao-m-santos joao-m-santos requested a review from a team as a code owner August 4, 2023 13:36
@joao-m-santos joao-m-santos force-pushed the 234-improverefactor-alluvial-code branch from 407e8cb to 59e6565 Compare August 4, 2023 13:37
govind-srinidhi
govind-srinidhi previously approved these changes Aug 4, 2023
View reviewed changes
@joao-m-santos joao-m-santos force-pushed the 234-improverefactor-alluvial-code branch from 59e6565 to 0a4348e Compare August 31, 2023 14:46
@joao-m-santos joao-m-santos merged commit be1850b into main Aug 31, 2023
8 checks passed
@joao-m-santos joao-m-santos deleted the 234-improverefactor-alluvial-code branch September 25, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@govind-srinidhi govind-srinidhi govind-srinidhi approved these changes

Assignees

@joao-m-santos joao-m-santos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve/refactor Alluvial code
2 participants
@joao-m-santos @govind-srinidhi