Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🩹 Increase skip safety margin #322

Merged
merged 1 commit into from
Oct 20, 2023
Merged

🩹 Increase skip safety margin #322

merged 1 commit into from
Oct 20, 2023

Conversation

joao-m-santos
Copy link
Contributor

📝 Description

  • Increase safety margin from 15% to 20% in tick skip logic

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@joao-m-santos joao-m-santos self-assigned this Oct 20, 2023
@joao-m-santos joao-m-santos requested a review from a team as a code owner October 20, 2023 12:02
@netlify
Copy link

netlify bot commented Oct 20, 2023 •
edited
Loading

✅ Deploy Preview for adyen-lume ready!

Name Link
🔨 Latest commit 7503181
🔍 Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/65326c650dc512000834481f
😎 Deploy Preview https://deploy-preview-322--adyen-lume.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joao-m-santos joao-m-santos merged commit 10035ce into main Oct 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@govind-srinidhi govind-srinidhi govind-srinidhi approved these changes

Assignees

@joao-m-santos joao-m-santos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joao-m-santos @govind-srinidhi