Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix axis alignment when scale domain is 0 to 0 #481

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

joao-m-santos
Copy link
Contributor

📝 Description

Fixes axes alignment when scale domain is zeros. This happens, for instance, when all dataset values are 0.

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

--

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@joao-m-santos joao-m-santos self-assigned this Nov 11, 2024
@joao-m-santos joao-m-santos requested a review from a team as a code owner November 11, 2024 14:30
Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for adyen-lume ready!

Name Link
🔨 Latest commit a343e61
🔍 Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/6732151dd0f9020008030728
😎 Deploy Preview https://deploy-preview-481--adyen-lume.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Nov 11, 2024

@joao-m-santos joao-m-santos merged commit bf10433 into main Nov 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants