Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Travel Debugging #323

Merged

Conversation

HowieG
Copy link
Contributor

@HowieG HowieG commented Jul 31, 2024

📥 Pull Request

📘 Description
Adding ability to cache LLM Calls with edited completions

🔄 Related Issue (if applicable)
Resolves ENG-305

🧪 Testing
tests/test_time_travel.py

@HowieG HowieG requested review from siyangqiu and bboynton97 July 31, 2024 01:21
@HowieG HowieG enabled auto-merge (squash) July 31, 2024 01:21
HowieG and others added 3 commits July 31, 2024 12:47
* embed notebook html directly, not iframe

* delete iframe script
* allow naming in agent constructor

* allow naming in agent constructor

* formatting

* moved to decorators

* doc kwarg update

* remove empty file
Copy link
Contributor

@siyangqiu siyangqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments to address, but 🚀🚀🚀

tests/test_time_travel.py Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
agentops/cli.py Outdated Show resolved Hide resolved
agentops/time_travel.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 17.17791% with 135 lines in your changes missing coverage. Please review.

Files Patch % Lines
agentops/time_travel.py 20.00% 72 Missing ⚠️
agentops/llm_tracker.py 12.00% 44 Missing ⚠️
agentops/cli.py 0.00% 19 Missing ⚠️
Flag Coverage Δ
unittests 43.79% <17.17%> (-1.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
agentops/decorators.py 68.26% <100.00%> (+14.26%) ⬆️
agentops/cli.py 0.00% <0.00%> (ø)
agentops/llm_tracker.py 8.90% <12.00%> (+0.36%) ⬆️
agentops/time_travel.py 20.00% <20.00%> (ø)

... and 1 file with indirect coverage changes

agentops/time_travel.py Outdated Show resolved Hide resolved
@bboynton97
Copy link
Contributor

Can we add unit tests for as much of this as possible?

@HowieG
Copy link
Contributor Author

HowieG commented Jul 31, 2024

@bboynton97 no

@HowieG HowieG merged commit de23413 into main Aug 1, 2024
11 checks passed
@HowieG HowieG deleted the i-wish-i-could-time-travel-and-avoid-breaking-my-commit-history branch August 1, 2024 00:23
siyangqiu pushed a commit that referenced this pull request Aug 2, 2024
* First attempt at merge

* Small fixes to time_travel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants