Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add packaging dependency to pyproject.toml #654

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

teocns
Copy link
Contributor

@teocns teocns commented Jan 21, 2025

While packaging is a direct dependency of build tools such as setuptools, it is important to mention that such dependency is only installed within the build environment.

When referenced in the codebase (from packaging import version), it needs to be explicitly listed dependency in pyproject.toml

@teocns teocns requested a review from areibman January 21, 2025 14:52
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@teocns teocns merged commit 180e853 into main Jan 22, 2025
9 checks passed
@teocns teocns deleted the fix/packacking-dependency branch January 22, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants