-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily running nightly every hour now to fix #1757
Conversation
kessler-frost
commented
Aug 21, 2023
•
edited
Loading
edited
- I have added the tests to cover my changes.
- I have updated the documentation and CHANGELOG accordingly.
- I have read the CONTRIBUTING document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving but would like to know the reasoning on why it would succeed on an hourly basis rather than daily. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @kessler-frost
@kessler-frost just noticed the seed data was changed and is causing one of the tests to fail, was the changes to the seed data intentional here ? |
@AmmarAgnostiq oh, it's more so that if it fails, it'll fail quicker and we'll get to see why it did so. @AlejandroEsquivel I did change time for some of the seed data because they're missing a 0 in the nightly: https://github.com/AgnostiqHQ/covalent/actions/runs/5921818377/job/16054901914 |
|
fc06a0b
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1757 +/- ##
========================================
Coverage 88.20% 88.20%
========================================
Files 191 191
Lines 8217 8217
Branches 151 151
========================================
Hits 7248 7248
Misses 864 864
Partials 105 105
|