Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily running nightly every hour now to fix #1757

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

kessler-frost
Copy link
Member

@kessler-frost kessler-frost commented Aug 21, 2023

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@kessler-frost kessler-frost marked this pull request as ready for review August 21, 2023 12:47
@kessler-frost kessler-frost requested review from a team as code owners August 21, 2023 12:47
AmmarAgnostiq
AmmarAgnostiq previously approved these changes Aug 21, 2023
Copy link

@AmmarAgnostiq AmmarAgnostiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving but would like to know the reasoning on why it would succeed on an hourly basis rather than daily. Thanks.

Copy link
Contributor

@AlejandroEsquivel AlejandroEsquivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @kessler-frost

@AlejandroEsquivel
Copy link
Contributor

@kessler-frost just noticed the seed data was changed and is causing one of the tests to fail, was the changes to the seed data intentional here ?

@kessler-frost
Copy link
Member Author

@AmmarAgnostiq oh, it's more so that if it fails, it'll fail quicker and we'll get to see why it did so. @AlejandroEsquivel I did change time for some of the seed data because they're missing a 0 in the nightly: https://github.com/AgnostiqHQ/covalent/actions/runs/5921818377/job/16054901914

@kessler-frost
Copy link
Member Author

kessler-frost commented Aug 21, 2023

It's failing for another one now, so I guess I'll have to add a 0 in a more "universal" way cuz of the assertion error. Could you take a quick look, I think there might be a better solution here rather than just adding a 0?
CC: @AlejandroEsquivel
Edit: Nvm, it seems like the decimal precision was supposed to be up to 6 digits in the places where it has changed, it's only up to 5 digits.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1757 (fc06a0b) into develop (eec8d77) will not change coverage.
The diff coverage is n/a.

❗ Current head fc06a0b differs from pull request most recent head baf7210. Consider uploading reports for the commit baf7210 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1757   +/-   ##
========================================
  Coverage    88.20%   88.20%           
========================================
  Files          191      191           
  Lines         8217     8217           
  Branches       151      151           
========================================
  Hits          7248     7248           
  Misses         864      864           
  Partials       105      105           
Flag Coverage Δ
Dispatcher 86.68% <ø> (ø)
Functional_Tests 56.25% <ø> (ø)
SDK 91.49% <ø> (ø)
UI_Backend 91.15% <ø> (ø)
UI_Frontend 72.64% <ø> (ø)

@AlejandroEsquivel AlejandroEsquivel enabled auto-merge (squash) August 21, 2023 17:43
@AlejandroEsquivel AlejandroEsquivel merged commit 11580b9 into develop Aug 21, 2023
9 checks passed
@AlejandroEsquivel AlejandroEsquivel deleted the fixing-nightly branch August 21, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants