Abstract API base endpoint #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjao
force-pushed
the
abstract-apis
branch
2 times, most recently
from
81bf303
to
2a2b22f
Compare
Since Sqlalchemy is only used server-side, it's an extraneous dependency of the SDK-only install
Accessing electron attributes directly in `Electron.__call__` can cause problems if those attributes happen to be missing.
cjao
force-pushed
the
abstract-apis
branch
5 times, most recently
from
be74191
to
ca95ba3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1950 +/- ##
===========================================
- Coverage 84.60% 84.25% -0.35%
===========================================
Files 295 293 -2
Lines 14499 14218 -281
Branches 195 195
===========================================
- Hits 12267 11980 -287
- Misses 2098 2104 +6
Partials 134 134
|
- named_args - named_kwargs - cova_imports - lattice_imports
This no longer works and should no longer be needed anyway since the migration from Result pickles to DB two years ago.
santoshkumarradha
previously approved these changes
May 29, 2024
cjao
dismissed stale reviews from santoshkumarradha and kessler-frost
via
8df33f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other cleanup and optimizations: