-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting - add Ruff and Black #23
Conversation
@t-sasatani any objections to my linter rules here? lmk if there are any you find annoying or wish we had |
Thanks, I looked into your code changes (which I believe indicate these rules), and I think they look good. I haven't used these before, so I'm not sure what coding with this will be like to be honest, but I think we can just start and think later. |
Ill write some docs on how to set it up to be more or less automatic :) these integrate pretty well with most IDEs |
I review this pull request and declare it to be good |
builds off: #21
since it's about to be merged.
Seems like we're going to get into trouble with our linting sooner rather than later now that work has begun on this in earnest.
Added black and ruff checks in CI, and started getting the package in line with them. Will add docs on how to do this during development but it's super simple (we can set this up as a pre-commit action, but otherwise it's just
black miniscope_io && ruff check
).gotta run for now, but it's super mechanical work, nothing too tricky, and should all be totally function neutral.