Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annoying pydantic warnings #74

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

sneakers-the-rat
Copy link
Collaborator

@sneakers-the-rat sneakers-the-rat commented Nov 12, 2024

Currently the test output is a total clusterfuck because of warnings emitted when writing the header data.

The warnings come because we're using model_construct() to create the header models, which skips the validation and coercion step, so we have numpy ints/floats instead of base python ints/floats. They serialize just fine, so it's safe to just ignore the warning there.

Also fixed a warning from python thinking we're trying to escape ``'['` instead of making a rich format string, so changed that to a raw string.

now there are no noisy warnings!


📚 Documentation preview 📚: https://miniscope-io--74.org.readthedocs.build/en/74/

@sneakers-the-rat
Copy link
Collaborator Author

this one is uncontroversial so i'm just gonna YOLO merge it

@coveralls
Copy link
Collaborator

coveralls commented Nov 12, 2024

Coverage Status

coverage: 77.17%. remained the same
when pulling a28f452 on fix-pydantic-serialization-warning
into 722552a on main.

@sneakers-the-rat sneakers-the-rat merged commit f6b05cd into main Nov 12, 2024
14 checks passed
@sneakers-the-rat sneakers-the-rat deleted the fix-pydantic-serialization-warning branch December 13, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants