[Not for merge] Document config file version #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12210063539Details
💛 - Coveralls |
|
|
||
| def get_version_from_commit(commit_id): | ||
| result = subprocess.run( | ||
| ["git", "describe", "--tags", commit_id], |
There was a problem hiding this comment.
Just so ya know, this is what the dynamic versioning does
There was a problem hiding this comment.
Yeah, I just stuck together git commands because I couldn't instantly figure out how to get the dynamic version for the last time the file was updated, and I wasn't thinking about merging this anyway.
t-sasatani
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for testing
📚 Documentation preview 📚: https://miniscope-io--84.org.readthedocs.build/en/84/