Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Soul Crystal health modifier to be static instead of percentage based #510

Closed
wants to merge 2 commits into from

Conversation

noolaan
Copy link

@noolaan noolaan commented Jun 25, 2024

This change would work well if a mod/modpack was to change the default number of hearts.

noolaan added 2 commits June 25, 2024 01:27
This change would work well if a mod/modpack was to change the default number of hearts.
@Aizistral
Copy link
Member

Aizistral commented Jul 20, 2024

Percentage is intended here specifically because of the mods that might change the amount of health a player has. So, if some mod out there gives them +20 HP for a total of 40, each soul crystal should represent 2 hearts instead of one. In this way, crystal loss cannot be overcome or made insignificant with just some health upgrades. This also avoids the issue of where and how to set the limit for how many crystals a player may lose, which becomes rather complex if each crystal stands for a fixed amount of health, and the total health is dynamic.

@Aizistral Aizistral closed this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants