Add branding-bar for desktop and mobile #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…celona into feat/brand-bar
fblupi
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Margins right and left are different. I would remove them using the same margins they use in https://www.barcelona.cat
It also breaks the horizontal scroll on several pages like the login page.
fblupi
approved these changes
Oct 31, 2024
fblupi
requested changes
Oct 31, 2024
…idim-barcelona into feat/brand-bar
fblupi
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
We need a branding bar that links to barcelona.cat and ajuntament.barcelona.cat, similar to https://www.barcelona.cat/ca
📋 Subtasks
📷 Screenshots (optional)