Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change references to the renamed create_dmg and get_repo.sh files. #894

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dougluce
Copy link

@dougluce dougluce commented Dec 4, 2024

Change references to the renamed create_dmg and get_repo.sh files.

Done due to the local renaming from these commits:

commit c4ee4f2b9a02d3f35a14c1776c424a6b8dd73042
Author: Alexander Frick <Alex313031@gmail.com>
Date:   Tue Feb 20 00:17:40 2024 -0600

     minor 206 uprev for ThOS

  ...
  build_dmg.sh => create_dmg.sh    |   0
  ...

commit bcc54f7bda9c5efe7ba4d6529b04eaa6e183a911
Author: Alexander Frick <Alex313031@gmail.com>
Date:   Tue Aug 20 14:26:49 2024 -0500

     update wrappers, scripts, and Th24 UI

  ...
  infra/install_deps.sh => get_repo.sh              |    0
  ...

Copy link
Collaborator

@gz83 gz83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be for pure renaming, you should not introduce other unrelated changes.

@dougluce
Copy link
Author

dougluce commented Dec 4, 2024

Yup, including more was accidental.

Copy link
Collaborator

@gz83 gz83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still contains irrelevant changes

@dougluce
Copy link
Author

dougluce commented Dec 4, 2024

Which change are you referring to?

@gz83
Copy link
Collaborator

gz83 commented Dec 4, 2024

infra/set_exec.sh

In addition, if build_dmg.sh exists in other files, please change them as well.

@dougluce dougluce changed the title Change supporting mentions of create_dmg Change references to the renamed create_dmg and get_repo.sh files. Dec 4, 2024
@dougluce
Copy link
Author

dougluce commented Dec 4, 2024

I've updated the commit message to encompass the other change.

This already covers the other mentions of build_dmg.sh that I was able to find.

infra/set_exec.sh Show resolved Hide resolved
Copy link
Collaborator

@gz83 gz83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New comment attached

Done due to the local renaming from these commits:

    commit c4ee4f2
    Author: Alexander Frick <Alex313031@gmail.com>
    Date:   Tue Feb 20 00:17:40 2024 -0600

         minor 206 uprev for ThOS

     ...
     build_dmg.sh => create_dmg.sh    |   0
     ...

    commit bcc54f7
    Author: Alexander Frick <Alex313031@gmail.com>
    Date:   Tue Aug 20 14:26:49 2024 -0500

         update wrappers, scripts, and Th24 UI

     ...
     infra/install_deps.sh => get_repo.sh              |    0
     ...
@gz83 gz83 requested a review from Alex313031 December 9, 2024 03:56
@gz83
Copy link
Collaborator

gz83 commented Dec 9, 2024

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants