-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change references to the renamed create_dmg and get_repo.sh files. #894
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should be for pure renaming, you should not introduce other unrelated changes.
f428eaa
to
1749c97
Compare
Yup, including more was accidental. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still contains irrelevant changes
Which change are you referring to? |
infra/set_exec.sh In addition, if build_dmg.sh exists in other files, please change them as well. |
1749c97
to
2cec1e2
Compare
I've updated the commit message to encompass the other change. This already covers the other mentions of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New comment attached
Done due to the local renaming from these commits: commit c4ee4f2 Author: Alexander Frick <Alex313031@gmail.com> Date: Tue Feb 20 00:17:40 2024 -0600 minor 206 uprev for ThOS ... build_dmg.sh => create_dmg.sh | 0 ... commit bcc54f7 Author: Alexander Frick <Alex313031@gmail.com> Date: Tue Aug 20 14:26:49 2024 -0500 update wrappers, scripts, and Th24 UI ... infra/install_deps.sh => get_repo.sh | 0 ...
2cec1e2
to
4d11bfb
Compare
LGTM |
Change references to the renamed
create_dmg
andget_repo.sh
files.Done due to the local renaming from these commits: