dev-petros - Branch Optimization #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed update_io_ports from update_partitions of Network class
…ting of a graph in split_graph_vertical
…Chop prototxt nodes
…d Partition classes respectively
Yu-Zhewen
approved these changes
Nov 7, 2023
| @@ -76,4 +79,67 @@ def plot_percentage_resource_per_layer_type(self, output_path=None): | |||
| if output_path == None: | |||
| plt.show() | |||
|
|
|||
|
|
|||
| def visualise_partitions_nx(self, output_path): | |||
There was a problem hiding this comment.
there is already a "visualise" function in Network.py, and I am not sure how they are different
There was a problem hiding this comment.
Actually, I created this one before seeing that there was another one doing the same thing.
In any case, the original Network visualise function depends on the visualise functions for each layer of the graph, which are not always implemented and are currently a bit buggy.
I kept this one as I need to check the partitions and how they are structured (mostly as a debugging tool).
We might drop this before merging, BUT we need to fix the other one in that case.
…ling due to really small number of weights and bram/uram usage being 0
… streaming feature support
…ess functions. Changed the implementation to take into consideration a broader pool of cases regarding the connections in branches
3D support and fixes on pipeline depth calculation
|
Are we happy to merge this, even if it is failing tests at the moment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.