449 check client urls #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
…examples into davidsmejia/449-check-client-urls
jashapiro
approved these changes
Jul 16, 2021
|
Task failed successfully: |
davidsmejia
added a commit
that referenced
this pull request
Jul 16, 2021
This reverts commit a2311ae.
davidsmejia
added a commit
that referenced
this pull request
Jul 16, 2021
* add github action and script to check front end urls on front end production * fix name * use stringr functions Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org> * move strsplit outside of loop Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org> * use any + stringr:str_detect Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org> * append -> c * fix url source * test the action on this push * remove testing hook * add one more test that should fail * test on push * making sure it used the correct list * unique the expected files * add missing semicolon * fix how path ids are merged into the missing list * R style points * remove testing event hook Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
davidsmejia
added a commit
that referenced
this pull request
Jul 16, 2021
* 449 check client urls (#460) * add github action and script to check front end urls on front end production * fix name * use stringr functions Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org> * move strsplit outside of loop Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org> * use any + stringr:str_detect Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org> * append -> c * fix url source * test the action on this push * remove testing hook * add one more test that should fail * test on push * making sure it used the correct list * unique the expected files * add missing semicolon * fix how path ids are merged into the missing list * R style points * remove testing event hook Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org> * 449 check client urls (#468) * add github action and script to check front end urls on front end production * fix name * use stringr functions Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org> * move strsplit outside of loop Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org> * use any + stringr:str_detect Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org> * append -> c * fix url source * test the action on this push * remove testing hook * add one more test that should fail * test on push * making sure it used the correct list * unique the expected files * add missing semicolon * fix how path ids are merged into the missing list * R style points * remove testing event hook * use the production links list Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org> Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as before, but will merge after the new homepage changes are up.
Purpose
masterbranch with a url pointing to refinebio-frontend production list of refinebio-examples' urlsFor any subsequent PRs, their checks will fail and present a list of the missing files and ids that correspond to any would be broken link. In order to pass you can request changes on the refinebio-frontend and rerun the
Check Refinebio Frontend Urlsaction after the updates are deployed to get a passing result.Issue addressed
#449
Gotchas the reviewer should know about
The order of PRs that should be merged would be
Remaining concerns and questions
I think logistically an improvement would be for the action to run both on
masterandstagingprs to match against refinebio-frontendmasterordevbranch so staging so they could both be deployed at the same time.