Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Publication Lists #23

Merged
merged 15 commits into from
Jun 14, 2024
Merged

Add Publication Lists #23

merged 15 commits into from
Jun 14, 2024

Conversation

jpfairbanks
Copy link
Member

I am adding some automation for generating the publication list from markdown files.

Copy link

github-actions bot commented Jun 13, 2024

@github-actions github-actions bot temporarily deployed to pull request June 13, 2024 18:05 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 14, 2024 17:08 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 14, 2024 17:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 14, 2024 17:29 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 14, 2024 18:10 Inactive
@GeorgeR227
Copy link
Contributor

GeorgeR227 commented Jun 14, 2024

@jpfairbanks Are there supposed to be images showing up on the Decapodes papers details pages? For example, https://666c87aa1733a4f46a4db57e--glowing-yeot-7d1daa.netlify.app/publications/diagrampresentations/diagrampresentations.

@jpfairbanks
Copy link
Member Author

Yeah they are relative paths are probably wrong

@GeorgeR227
Copy link
Contributor

The path itself seems fine, looking into it, the problem might be that the image label in the title block is not a valid one. It seems like preprint and publication don't show up either (confirmed by inspecting the web elements) but doi does since since this does show up in the quarto docs.

image

Either we can leave it as is for now, since I think the page looks fine even without this or I could try to include the image lower in the page.

@github-actions github-actions bot temporarily deployed to pull request June 14, 2024 19:24 Inactive
Resized and removed captions
@github-actions github-actions bot temporarily deployed to pull request June 14, 2024 19:44 Inactive
This reverts commit 784248b.
This reverts commit a5e3a7a.
@GeorgeR227
Copy link
Contributor

I've removed my changes here so I don't hold up the merging. I'll make a new branch with my changes that can be reviewed later.

@github-actions github-actions bot temporarily deployed to pull request June 14, 2024 20:08 Inactive
@GeorgeR227 GeorgeR227 merged commit 554d218 into main Jun 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants