-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks implementations #314
Conversation
Another question. Why not add the ability to add multiple |
Hello, |
ok |
I think you may have misunderstood the base component. The base component depends on block instead of property |
Indeed, I misunderstood |
Any way, thanks for the contributions! (Even when I haven't write docs for the component system) |
I'll come back to that. The "problem" with the base component depending on the block is that once all the drops are added, each block will have almost that class and won't be able to share like for example the leaves. For me (and this is why I misunderstood) the word |
I fully understand and agree what you said. This is indeed a problem and I will take your suggestion into consideration. |
if you want, i can do this change in this pr |
I have an idea, we can create a processor for each block property. When a block is being placed, we foreach the block's properties and then find processor for each property, let's the processor decide the block property's value based on the placement information |
Can you join our discord server to have more detailed discussion? We haven't decide the solution |
Move to #341 |
This pr is not finished.
I have just a question, why there are
BlockTypeDefaultInitializer
andBlockTypeInitializer
?