bugfix/parse-missing-wavelength #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlambert03
reviewed
Dec 13, 2024
xslt/Instrument.xsl
Outdated
| <xsl:when test="LightSourceType/Laser"> | ||
| <xsl:element name="ome:Laser"> | ||
| <xsl:attribute name="ID"> | ||
| <xsl:text>LightSource:</xsl:text> |
There was a problem hiding this comment.
fwiw ... this general pattern applies to all of the ID fields in the schema. See the respective fields in the OME schema and you'll see the rules for the respective fields
There was a problem hiding this comment.
@BrianWhitneyAI want to open a separate ticket to review our naming/usage to make sure this is satisfied everywhere?
toloudis
approved these changes
Dec 13, 2024
|
Oh also maybe a unit test for this would be interesting. |
toloudis
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a response to bioio-devs/bioio-czi#19 (comment). Our current transform from the czi schema to the OME schema does not account for an empty wavelength leading to parsing issues. Additionally, light sources need to be prefaced with "LightSource:"