Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rich presence timing issue #224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

entrypointkr
Copy link

I had some investigation, even this plugin tries restart every 20 seconds, discord-rpc reconnection time is 60 seconds.
Therfore, this is a minimal changes to make discord-rpc properly work.

Fixes #223

@dnbln dnbln added area: plugin type: fix Iterations on existing features or infrastructure. state: open labels Jun 24, 2022
@JasonLovesDoggo
Copy link

will this ever be merged?

@Almighty-Alpaca
Copy link
Owner

Sorry, forgot about this when working on the last release. That being said I don't really see the reason for this change.

discord-rpc reconnection time is 60 seconds

This isn't really true at all, it says it right above the linked line. discord-rpc starts at a delay of 500ms and goes up to 60 seconds when repeatedly trying to reconnect, it doesn't just start at 60 seconds.
Ideally the plugin would use an exponential backoff as well, but I don't see how just changing the delay to 60 seconds solves anything

@entrypointkr
Copy link
Author

@Almighty-Alpaca The rpc reconn time seems reset when try reconnect earlier. If I start the plugin without Discord, then the rpc reconnection time will gets longer than the plugin reconn time, after that we can’t never get connection using current 20 seconds. Then, how about get 1 to 120 seconds exponential backoff instead?

@JasonLovesDoggo
Copy link

@Almighty-Alpaca ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: plugin state: open type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't work if Discord started earlier than this plugin
4 participants