Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gradle cache files being detected as Gradle DSL files #412

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Davoleo
Copy link

@Davoleo Davoleo commented Apr 9, 2024

  • Removing .gradle/ path matching

I have checked the contents of .gradle folder inside projects and it mostly contains intermediate building files users should never touch + gradle dependencies sources and classes.

As such I'm removing the matcher line that overrides detection for file extensions inside those folder to use Gradle asset.
This allows library sources to be detected as their original language while still keeping files with the .gradle extension to be detected by the gradle flavors.

This also doesn't break projects that use multiple .gradle DSL files to handle gradle project build as they'd still be recognized by the Gradle Groovy flavor.

Known issue: this doesn't seem to fix .gradle.kts files that are still detected as "Kotlin Script" instead of Gradle Kotlin.
But I don't know how to give priority to this extension instead of the standard Kotlin Script one, feel free to suggest changes though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant