Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to use callWidgetFactory without events #936

Merged

Conversation

quentinderoubaix
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.34%. Comparing base (95166dd) to head (4190640).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
+ Coverage   95.27%   95.34%   +0.07%     
==========================================
  Files          90       91       +1     
  Lines        2453     2494      +41     
  Branches      405      417      +12     
==========================================
+ Hits         2337     2378      +41     
  Misses        113      113              
  Partials        3        3              
Flag Coverage Δ
e2e 89.34% <ø> (ø)
unit 88.53% <ø> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andreascorti andreascorti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @quentinderoubaix

@quentinderoubaix
Copy link
Contributor Author

thx for the review @andreascorti !

@quentinderoubaix quentinderoubaix merged commit 6064526 into AmadeusITGroup:main Sep 23, 2024
16 checks passed
@quentinderoubaix quentinderoubaix deleted the svelte-events-optional branch September 23, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants