Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collapse): add accessibility elements of the collapse #973

Closed
wants to merge 1 commit into from

Conversation

ExFlo
Copy link
Contributor

@ExFlo ExFlo commented Oct 25, 2024

Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guidelines
  • Reference your PR to an issue that was discussed ahead of time
  • The PR should contain a clear description of the problem it solves
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the unit tests with npm run test
  • Run the linting with npm run lint
  • Run the e2e tests with npm run e2e

Thank you for contributing to AgnosUI!

@ExFlo ExFlo force-pushed the feat/collapseaccessibility branch from 3a76170 to dcf349f Compare October 25, 2024 12:18
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.10%. Comparing base (e311275) to head (484a87e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #973   +/-   ##
=======================================
  Coverage   92.10%   92.10%           
=======================================
  Files          94       94           
  Lines        2532     2533    +1     
  Branches      421      421           
=======================================
+ Hits         2332     2333    +1     
  Misses        130      130           
  Partials       70       70           
Flag Coverage Δ
e2e 83.17% <100.00%> (+<0.01%) ⬆️
unit 85.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quentinderoubaix quentinderoubaix force-pushed the feat/collapseaccessibility branch from 2a3cbdb to 75a5205 Compare October 26, 2024 12:18
@ExFlo ExFlo force-pushed the feat/collapseaccessibility branch 3 times, most recently from f8942e0 to 0b70600 Compare October 28, 2024 20:35
@ExFlo ExFlo force-pushed the feat/collapseaccessibility branch from 0b70600 to 484a87e Compare October 28, 2024 20:39
@ExFlo ExFlo closed this Oct 28, 2024
@ExFlo ExFlo deleted the feat/collapseaccessibility branch October 28, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants