Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Do not call equal with an uninitialized value #106

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File renamed without changes.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: '16.x'
node-version: '18.x'
- uses: actions/cache@v3
with:
path: .yarn/cache
Expand All @@ -21,8 +21,8 @@ jobs:
- run: yarn --immutable
- run: yarn lint
- run: yarn format:check
- run: yarn test
- uses: codecov/codecov-action@d9f34f8cd5cb3b3eb79b3e4b5dae3a16df499a70 #v3.1.1
- run: yarn test --coverage
- uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d #v3.1.4
with:
file: coverage/lcov.info
- run: yarn build
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ jobs:
release:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: '16.x'
node-version: '18.x'
- run: yarn --immutable
- name: npm version
working-directory: src
Expand All @@ -37,7 +37,7 @@ jobs:
- name: npm logout
run: rm ~/.npmrc
- run: git push origin master v${{ inputs.version }}
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: gh-pages
path: gh-pages
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,17 @@ jobs:
update:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Set Node.js version
uses: actions/setup-node@v3
with:
node-version: '16.x'
node-version: '18.x'
- run: yarn set version stable
- run: yarn install --no-immutable
- run: yarn up --caret '**'
- run: yarn up -R '**'
- name: Create pull request
uses: peter-evans/create-pull-request@b4d51739f96fca8047ad065eccef63442d8e99f7 # v4.2.0
uses: peter-evans/create-pull-request@153407881ec5c347639a548ade7d8ad1d6740e38 # v5.0.2
with:
commit-message: 'chore: Update all dependencies'
branch: dependencies
Expand Down
2 changes: 1 addition & 1 deletion DEVELOPER.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Run:

- `yarn test` to execute unit tests.
- `yarn test-tdd` to execute unit tests in the TDD mode (tests are re-run on each change).
- `yarn tdd` or `yarn tdd:ui` to execute unit tests in the TDD mode (tests are re-run on each change).
- `yarn build` to build the lib
- `yarn format:check` to check that files are correctly formatted
- `yarn format:fix` to reformat files
Expand Down
36 changes: 0 additions & 36 deletions angular.json

This file was deleted.

8 changes: 0 additions & 8 deletions karma.ci.conf.js

This file was deleted.

32 changes: 0 additions & 32 deletions karma.conf.js

This file was deleted.

20 changes: 8 additions & 12 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "@amadeus-it-group/tansu",
"type": "module",
"devDependencies": {
"@angular-devkit/build-angular": "^16.2.4",
"@angular/cli": "^16.2.4",
"@angular/common": "^16.2.7",
"@angular/compiler": "^16.2.7",
"@angular/compiler-cli": "^16.2.7",
Expand All @@ -14,30 +13,27 @@
"@microsoft/api-documenter": "^7.23.9",
"@microsoft/api-extractor": "^7.38.0",
"@rollup/plugin-typescript": "^11.1.4",
"@types/jasmine": "^4.3.6",
"@typescript-eslint/eslint-plugin": "^6.7.3",
"@typescript-eslint/parser": "^6.7.3",
"@vitest/coverage-istanbul": "^0.34.6",
"@vitest/ui": "^0.34.6",
"eslint": "^8.50.0",
"eslint-config-prettier": "^9.0.0",
"happy-dom": "^12.6.0",
"husky": "^8.0.3",
"jasmine-core": "^5.1.1",
"jasmine-spec-reporter": "^7.0.0",
"karma": "^6.4.2",
"karma-chrome-launcher": "^3.2.0",
"karma-coverage": "^2.2.1",
"karma-jasmine": "^5.1.0",
"karma-jasmine-html-reporter": "^2.1.0",
"prettier": "^3.0.3",
"pretty-quick": "^3.1.3",
"rollup": "^3.29.4",
"rxjs": "^7.8.1",
"svelte": "^4.2.1",
"typescript": "^5.2.2",
"vitest": "^0.34.6",
"zone.js": "^0.14.0"
},
"scripts": {
"test": "ng test -c ci",
"test-tdd": "ng test",
"test": "vitest run",
"tdd": "vitest",
"tdd:ui": "vitest --ui",
"clean": "rm -rf dist temp",
"lint": "eslint src/{,**/}*.ts",
"build:rollup": "rollup --failAfterWarnings -c",
Expand Down
Loading