Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: more complete usage explanation in readme #121

Merged
merged 1 commit into from
Jan 15, 2024
Merged

doc: more complete usage explanation in readme #121

merged 1 commit into from
Jan 15, 2024

Conversation

fbasso
Copy link
Contributor

@fbasso fbasso commented Dec 26, 2023

No description provided.

@fbasso fbasso marked this pull request as draft December 26, 2023 14:52
@codecov Codecov
Copy link

codecov bot commented Dec 26, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f559ce) 98.65% compared to head (1a59087) 98.65%.

❗ Current head 1a59087 differs from pull request most recent head e9b99a8. Consider uploading reports for the commit e9b99a8 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files           1        1           
  Lines         372      372           
  Branches       67       67           
=======================================
  Hits          367      367           
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fbasso fbasso force-pushed the readme branch 15 times, most recently from 2672ea2 to 61cce33 Compare December 28, 2023 09:24
@fbasso fbasso marked this pull request as ready for review December 28, 2023 10:39
@fbasso fbasso requested review from divdavem and ExFlo December 28, 2023 10:39
@fbasso fbasso force-pushed the readme branch 2 times, most recently from d429a08 to f5f0c14 Compare January 9, 2024 09:17
andreascorti
andreascorti approved these changes Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@fbasso
Copy link
Contributor Author

fbasso commented Jan 11, 2024

Thanks for your reviews ! I pushed a new version.

divdavem
divdavem reviewed Jan 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
divdavem
divdavem reviewed Jan 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@fbasso fbasso force-pushed the readme branch 2 times, most recently from 17c22bd to 1a59087 Compare January 15, 2024 16:17
divdavem
divdavem approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@divdavem divdavem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. 👍

@fbasso fbasso merged commit ba79e99 into AmadeusITGroup:master Jan 15, 2024
1 check passed
@fbasso
Copy link
Contributor Author

fbasso commented Jan 15, 2024

Thanks for your reviews !

@fbasso fbasso deleted the readme branch December 26, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ExFlo ExFlo ExFlo approved these changes

@andreascorti andreascorti andreascorti approved these changes

@divdavem divdavem divdavem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fbasso @divdavem @andreascorti @ExFlo