Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for AmpereOne family #6

Merged
merged 7 commits into from
May 14, 2024
Merged

Support for AmpereOne family #6

merged 7 commits into from
May 14, 2024

Conversation

binh-ampere
Copy link
Collaborator

@binh-ampere binh-ampere commented Apr 26, 2024 •
edited
Loading

Support for AmpereOne family

Ampere's newest processor, AmpereOne, has architecture-specific build options to improve performance through better code generation. This PR is aimed to detect software built for the Arm Neoverse series of processors and recommend options for AmpereOne support.

Add detection for meson build files

This PR support detects meson build files for missing AmpereOne support.

Other changes

Extend other arch list with loongarch64, riscv64, sandybridge, zen, etc to reduce noise.
UT cases extended.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@naren-ampere
Copy link
Collaborator

Bin,
I would recommend the following text:

Support for AmpereOne family
Ampere's newest processor, AmpereOne, has architecture-specific build options to improve performance through better code generation. This PR is aimed to detect software built for the Arm Neoverse series of processors and recommend options for AmpereOne support.

Add detection for meson build files
This PR support detects meson build files for missing AmpereOne support.

Other changes
Extend other arch list with loongarch64, riscv64, sandybridge, zen, etc to reduce noise.
UT cases extended.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@binh-ampere
Copy link
Collaborator Author

Bin, I would recommend the following text:

Support for AmpereOne family Ampere's newest processor, AmpereOne, has architecture-specific build options to improve performance through better code generation. This PR is aimed to detect software built for the Arm Neoverse series of processors and recommend options for AmpereOne support.

Add detection for meson build files This PR support detects meson build files for missing AmpereOne support.

Other changes Extend other arch list with loongarch64, riscv64, sandybridge, zen, etc to reduce noise. UT cases extended.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks @naren-ampere , summary updated.

@davidz-ampere
Copy link
Collaborator

Looks good for me.

@binh-ampere binh-ampere changed the title Ampere1 dev Support for AmpereOne family May 14, 2024
davidz-ampere
davidz-ampere approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@davidz-ampere davidz-ampere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.
Thanks, Bin!

@binh-ampere binh-ampere merged commit 510aa13 into AmpereComputing:main May 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz-ampere davidz-ampere davidz-ampere approved these changes

@naren-ampere naren-ampere Awaiting requested review from naren-ampere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binh-ampere @naren-ampere @davidz-ampere