fix(edit profile picture): fix the page crash happening when clicking on circular border radius #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ircular border radius
googleknight
changed the title
|
@AmruthPillai Could you please review the fix ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1953
Issue
In profile picture edit section, when a user selects a circle border radius, clicks on the numeric input for the border radius, and then clicks outside, the
onBorderRadiusChangefunction is triggered and receives an empty string ("") as thevalue.Fix
So updated the code to check for empty string as being done in
onAspectRatioChangefunction.