-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add preview in dashboard using iframe #2032
base: main
Are you sure you want to change the base?
feat: add preview in dashboard using iframe #2032
Conversation
@AmruthPillai please review and merge if it's okay. Thank you! |
There is only one deprecation warning, related to
commit: 4d4f28d |
Review please 🙏 cc. @AmruthPillai |
@AmruthPillai What do you think? |
Small reminder 😄 Thank you! cc. @AmruthPillai |
@AmruthPillai Please review 😄 |
Hello @rinczefi-user ! |
It seems that this happens on Firefox. On Google chrome it shows ok. |
Hmm.. I see that it's supported only in the new Firefox versions.. 🤔 |
I'll try this suggestion 👇 later today, thanks! |
Changes:
useResumePreview
hook is currently unused, because huge loading timesResume/blob/main/apps/client/src/pages/public/page.tsx#L81-L86)
iframe
to render it and set resume in theuseEffect((), [frameRef])
💪 It is fast and from the exploratory tests I've done locally, we can rely on it, as well.