fix(printer): refine "localhost" matching in printer.service.ts #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed localhost matching for local dev environments from a url string match to more specific regex that matches host property. This was causing the "about:blank", no output error in (edge) case of printing a pdf from any url with string "localhost"
fix: refine "localhost" matching in printer.service.ts
|
this was an issue for me, but i think unlikely for many others |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: unable to print if url contains the word "localhost" in any location
resulting in the "about:blank", no output path
example:
http://nonlocalhoster.comwould be changed tohttp://nonhost.docker.internaler.comproposed:
change localhost matching for local dev environments from a url string match to more specific regex that matches host property.