Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIJN-8594-bsn-nummer-niet-meer-tonen-alg-user-e-xperience #124

Merged

Conversation

Anouk91
Copy link
Contributor

@Anouk91 Anouk91 commented Jun 7, 2024

Werkt door te deployen naar test!

Graag zou ik ook de test toevoegen waarbij het bsn wordt weggehaald, alleen de os.environ mock krijg ik niet aan de praat. Na wat google werk besloten het op te geven. Mocht jij het wel gelijk weten, dan hierbij de test die verder prima werkt.

@patch.dict(os.environ,{ "IS_SHOW_BSN_ENABLED": False})
def test_brp_show_no_bsn(self):
        response = self.get_secure("/brp/brp")
        self.assertEqual(response.status_code, 200)
        supposed_result = self._get_expected_private()["content"]
        del supposed_result["bsn"]
        self.assertEqual(response.json["content"]["persoon"], supposed_result)

@Anouk91 Anouk91 merged commit 790e0a0 into main Jun 7, 2024
5 checks passed
@Anouk91 Anouk91 deleted the MIJN-8594-bsn-nummer-niet-meer-tonen-alg-user-e-xperience branch June 7, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants