Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Set token to the default provided by GitHub workflow #483

Merged
merged 5 commits into from
Mar 5, 2024
Merged

feat: ✨ Set token to the default provided by GitHub workflow #483

merged 5 commits into from
Mar 5, 2024

Conversation

kdeldycke
Copy link
Contributor

Description

This is a small contribution to set the token to the default value provided by the GitHub workflow it is run from.

This should ease the onboarding process for new users.

Also make some slight formatting changes in the Markdown.

@AndreasAugustin
Copy link
Owner

@all-contributors please add @kdeldycke for code

Copy link
Contributor

@AndreasAugustin

I've put up a pull request to add @kdeldycke! 🎉

@AndreasAugustin
Copy link
Owner

AndreasAugustin commented Mar 5, 2024

@kdeldycke sorry for late response. Was super busy the last days.
Thanks for the PR. Makes totally sense.
Over all am not super sure why it was not this way from a starting point of view. Either lack of my knowledge or it was simply not possible back in time :)

Made a small adjustement:

  • adjusted the testing workflow files
  • adjusted the PR title -> release please needs conventional commits

@AndreasAugustin AndreasAugustin changed the title Set token to the default provided by GitHub workflow feat: ✨ Set token to the default provided by GitHub workflow Mar 5, 2024
@AndreasAugustin AndreasAugustin merged commit c1e7561 into AndreasAugustin:main Mar 5, 2024
2 checks passed
@AndreasAugustin AndreasAugustin added the enhancement New feature or request label Mar 5, 2024
@kdeldycke kdeldycke deleted the set-default-token branch March 6, 2024 10:09
@kdeldycke
Copy link
Contributor Author

Thanks @AndreasAugustin for merging my PR ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants