Skip to content

Commit

Permalink
Removed redundant notices/warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
ebronson68 committed Dec 8, 2023
1 parent c767ff6 commit 1651ad9
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/aks-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,12 @@ jobs:
if ($appConfig.adminingress) {
$adminIngressWhitelist = $appConfig.adminingress.annotations."nginx.ingress.kubernetes.io/whitelist-source-range" ?? "${{ inputs.adminIngressWhitelist }}"
if (![bool]($adminIngressWhitelist -match "^\d{1,3}(\.\d{1,3}){3}(\/\d{1,2})?(,\d{1,3}(\.\d{1,3}){3}(\/\d{1,2})?)*$")) {
Write-Output "::warning file=$valuesYamlPath::Invalid value set for 'adminingress.annotations.nginx.ingress.kubernetes.io/whitelist-source-range'. Defaulting to ${{ inputs.adminIngressWhitelist }} Value: $adminIngressWhitelist"
Write-Output "Invalid value set for 'adminingress.annotations.nginx.ingress.kubernetes.io/whitelist-source-range'. Defaulting to ${{ inputs.adminIngressWhitelist }} Value: $adminIngressWhitelist"
$adminIngressWhitelist = "${{ inputs.adminIngressWhitelist }}"
}
}
else {
Write-Output "::notice file=$valuesYamlPath::adminingress values not defined. Skipping setting adminIngressWhitelist"
Write-Output "adminingress values not defined. Skipping setting adminIngressWhitelist"
}
if ($environmentIngress -eq "true") {
Expand All @@ -183,7 +183,7 @@ jobs:
$hostName = "www"
}
}
Write-Output "::notice file=$valuesYamlPath::This application's hostname is $hostName.$domainName"
Write-Output "This application's hostname is $hostName.$domainName"
Write-Output "appName=$appName" >> $env:GITHUB_ENV
Write-Output "appVersion=$appVersion" >> $env:GITHUB_ENV
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bump-versions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
}
echo "release=$release" >> $env:GITHUB_ENV
echo "::notice::Bumping version to $release"
echo "Bumping version to $release"
- name: Update version in package.json
if: steps.packagejsonfile.outputs.files_exists == 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-azureapimanagement.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ jobs:
$ApiProductId = "${{ inputs.apiProductId }}"
$ApiSubscriptionRequired = ${{ inputs.apiSubscriptionRequired }}
echo "::notice::SwaggerURL: $SwaggerURL"
echo "SwaggerURL: $SwaggerURL"
if ("${{ inputs.apiId }}") {
$ApiId = "${{ inputs.apiId }}"
Expand Down

0 comments on commit 1651ad9

Please sign in to comment.