Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RECUR-186] Deploy versioned API specs #137

Merged
merged 9 commits into from
Jul 25, 2024

Conversation

ebronson68
Copy link
Contributor

@ebronson68 ebronson68 commented Jul 22, 2024

RECUR-186
Summary [DEVOPS] Research how to deploy v1 and v2 APIs separately
Type Story Story
Status In Progress
Points N/A
Labels -
---

Description

  • Set ingressWhitelist input in AKS deploy workflow to the KUBERNETES_INGRESS_WHITELIST repository variable and have it default to the value in the values.yaml and otherwise, default to 0.0.0.0/0
  • Have the API management update workflow run on self-hosted GitHub Runner in the amuaksdev101 cluster so that we can have a cloud VM/container pull down the swagger.json files by adding the AKS cluster node IPs to the ingressWhitelist list.
  • Remove API spec versions from Swagger JSONs to fix API URL paths
    Result:
    image
    image

Related Links

  • Jira Issue: RECUR-186
  • Testing environment: 🚀 Deploy

@ebronson68 ebronson68 requested a review from a team as a code owner July 22, 2024 17:52
@github-actions github-actions bot added Recurly Implementation story New feature or request devops DevOps Team labels Jul 22, 2024
Copy link

Let's make that PR title a 💯 shall we? 💪

Your PR title and story title look slightly different. Just checking in to know if it was intentional!

Story Title [DEVOPS] Research how to deploy v1 and v2 APIs separately
PR Title [RECUR-186] Deploy versioned API specs

Check out this guide to learn more about PR best-practices.

@ebronson68 ebronson68 marked this pull request as draft July 22, 2024 17:57
tburger010
tburger010 previously approved these changes Jul 22, 2024
@ebronson68 ebronson68 marked this pull request as ready for review July 25, 2024 14:55
@ebronson68 ebronson68 merged commit d9dd811 into main Jul 25, 2024
4 checks passed
@ebronson68 ebronson68 deleted the story/RECUR-186/deploy-versioned-api-specs branch July 25, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops DevOps Team Recurly Implementation story New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants