Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVOPS-513] Fix loop that sets key vault references for each environment variable #146

Merged
merged 16 commits into from
Aug 27, 2024
Merged

[DEVOPS-513] Fix loop that sets key vault references for each environment variable #146

merged 16 commits into from
Aug 27, 2024

Conversation

ebronson68
Copy link
Contributor

@ebronson68 ebronson68 commented Aug 27, 2024 •
edited
Loading

DEVOPS-513
Summary Azure Function deploy workflows not updating environment variables
Type Bug Bug
Status In Development Env
Points N/A
Labels -
---

Description

  • Fix loop that sets key vault references for each environment variable
    image

Related Links

@ebronson68
Switch to new line separator between environment vars
d3369c4
@ebronson68
Test get-envs DEVOPS-513 changes
8a0e406
@ebronson68
Try running env var step in sh, not azure cli
1176336
@ebronson68
Sent environmentVariables output to single quoted string
a0ddcc6
@ebronson68
Disabling strict errors in azure CLI session
cd7261b
@ebronson68
Just output something please
b48c316
@ebronson68
Remove -d option in read command
af4228c
@ebronson68
Add debugging statements
39c87b9
@ebronson68
Try setting env vars first
a633898
@ebronson68
Try piping out env vars directly to while loop
7fc9952
@ebronson68
Only update value if it isn't a key vault ref already
e44b818
@ebronson68
Check if variable exists for the specific slot
946ff9e
@ebronson68
trim trailing new line
41ae3c9
@ebronson68
Don't output all of the app settings every single time one gets updated
e9fa1cc
@ebronson68
Removing extra debugging statements
baa258d
@ebronson68
Switch back to v1 version of get-envs action
1f95eb5
@ebronson68 ebronson68 requested a review from a team as a code owner August 27, 2024 19:53
@github-actions github-actions bot added devops DevOps Team bug Something isn't working labels Aug 27, 2024
@github-actions GitHub Actions
Copy link

Let's make that PR title a 💯 shall we? 💪

Your PR title and story title look slightly different. Just checking in to know if it was intentional!

Story Title Azure Function deploy workflows not updating environment variables
PR Title [DEVOPS-513] Fix loop that sets key vault references for each environment variable

Check out this guide to learn more about PR best-practices.

tburger010
tburger010 approved these changes Aug 27, 2024
View reviewed changes
Copy link

@tburger010 tburger010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting use of sed on line 262.

@ebronson68
Copy link
Contributor Author

Interesting use of sed on line 262.

Yeah, that was suggested by Copilot. If it works...

@ebronson68 ebronson68 merged commit 087bd6f into main Aug 27, 2024
4 checks passed
@ebronson68 ebronson68 deleted the bug/DEVOPS-513/fix-environment-var-separator branch August 27, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tburger010 tburger010 tburger010 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working devops DevOps Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebronson68 @tburger010