Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVOPS-551] Fixing NGINX class ingress annotation deprecation warnings #157

Merged
merged 1 commit into from
Oct 23, 2024
Merged

[DEVOPS-551] Fixing NGINX class ingress annotation deprecation warnings #157

merged 1 commit into from
Oct 23, 2024

Conversation

ebronson68
Copy link
Contributor

@ebronson68 ebronson68 commented Oct 11, 2024 •
edited by github-actions bot
Loading

DEVOPS-551
Summary NGINX Kubernetes Ingress Class annotation is being deprecated
Type Maintenance Maintenance
Status In Development Env
Points N/A
Labels -
---

Description

  • Fixing NGINX class ingress annotation deprecation warnings

NOTE: I'm updating the K8s Helm templates to include the new ingress.ingressClassName setting in the values.yaml. Since this change only uses the value if it's used in the Helm charts, it does not break any deployments if the values.yaml file does not have the value set.

Related Links

  • Jira Issue: DEVOPS-551
  • Testing environment (confirming that the ingressClassName does not need to be set in the Helm charts for the deployments to pass): 🚀 Deploy

@ebronson68 ebronson68 requested a review from a team as a code owner October 11, 2024 15:23
@github-actions github-actions bot added devops DevOps Team maintenance Effort to retain operation and all capabilities labels Oct 11, 2024
@github-actions GitHub Actions
Copy link

I'm a bot and I 👍 this PR title. 🤖

<img src="https://media.giphy.com/media/XreQmk7ETCak0/giphy.gif" width="400" />

@ebronson68 ebronson68 merged commit 7307677 into main Oct 23, 2024
4 checks passed
@ebronson68 ebronson68 deleted the improv/DEVOPS-551/fixing-nginx-class-annotation-deprecation-warning branch October 23, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
devops DevOps Team maintenance Effort to retain operation and all capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ebronson68